iscsi-target: Propigate queue_data_in + queue_status errors
This patch changes iscsi-target to propagate iscsit_transport ->iscsit_queue_data_in() and ->iscsit_queue_status() callback errors, back up into target-core. This allows target-core to retry failed iscsit_transport callbacks using internal queue-full logic. Reported-by: Potnuri Bharat Teja <bharat@chelsio.com> Reviewed-by: Potnuri Bharat Teja <bharat@chelsio.com> Tested-by: Potnuri Bharat Teja <bharat@chelsio.com> Cc: Potnuri Bharat Teja <bharat@chelsio.com> Reported-by: Steve Wise <swise@opengridcomputing.com> Cc: Steve Wise <swise@opengridcomputing.com> Cc: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
@@ -567,7 +567,7 @@ static void iscsit_remove_cmd_from_immediate_queue(
|
||||
}
|
||||
}
|
||||
|
||||
void iscsit_add_cmd_to_response_queue(
|
||||
int iscsit_add_cmd_to_response_queue(
|
||||
struct iscsi_cmd *cmd,
|
||||
struct iscsi_conn *conn,
|
||||
u8 state)
|
||||
@@ -578,7 +578,7 @@ void iscsit_add_cmd_to_response_queue(
|
||||
if (!qr) {
|
||||
pr_err("Unable to allocate memory for"
|
||||
" struct iscsi_queue_req\n");
|
||||
return;
|
||||
return -ENOMEM;
|
||||
}
|
||||
INIT_LIST_HEAD(&qr->qr_list);
|
||||
qr->cmd = cmd;
|
||||
@@ -590,6 +590,7 @@ void iscsit_add_cmd_to_response_queue(
|
||||
spin_unlock_bh(&conn->response_queue_lock);
|
||||
|
||||
wake_up(&conn->queues_wq);
|
||||
return 0;
|
||||
}
|
||||
|
||||
struct iscsi_queue_req *iscsit_get_cmd_from_response_queue(struct iscsi_conn *conn)
|
||||
|
Reference in New Issue
Block a user