xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

phylib: convert state_queue work to delayed_work

Browse Source 
It closes a race in phy_stop_machine when reprogramming of phy_timer
(from phy_state_machine) happens between del_timer_sync and cancel_work_sync.

Without this change it could lead to crash if phy_device would be freed after
phy_stop_machine (timer would fire and schedule freed work).

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Marcin Slusarz
2009-03-13 15:41:19 -07:00
committed by David S. Miller
parent 34cd347cec
commit a390d1f379
2 changed files with 12 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
include/linux/phy.h
View File

@@ -315,8 +315,7 @@ struct phy_device {
/* Interrupt and Polling infrastructure */
struct work_struct phy_queue;
struct work_struct state_queue;
struct timer_list phy_timer;
struct delayed_work state_queue;
atomic_t irq_disable;
struct mutex lock;