xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num()

Browse Source 
[ Upstream commit f85450f134f0b4ca7e042dc3dc89155656a2299d ]

In function get_pkg_num() if fopen_or_die() succeeds it returns a file
pointer to be used. But fclose() is never called before returning from
the function.

Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Samasth Norway Ananda
2024-02-13 16:19:56 -08:00
committed by Greg Kroah-Hartman
parent 98e2b97acb
commit a2e43c53b8
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
View File

@@ -1152,6 +1152,7 @@ unsigned int get_pkg_num(int cpu)
retval = fscanf(fp, "%d\n", &pkg); retval = fscanf(fp, "%d\n", &pkg);
if (retval != 1) if (retval != 1)
errx(1, "%s: failed to parse", pathname); errx(1, "%s: failed to parse", pathname);
fclose(fp);
return pkg; return pkg;
} }