tcp: bool conversions
bool conversions where possible. __inline__ -> inline space cleanups Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
e005d193d5
commit
a2a385d627
@@ -866,14 +866,14 @@ static void tcp_v4_reqsk_destructor(struct request_sock *req)
|
||||
}
|
||||
|
||||
/*
|
||||
* Return 1 if a syncookie should be sent
|
||||
* Return true if a syncookie should be sent
|
||||
*/
|
||||
int tcp_syn_flood_action(struct sock *sk,
|
||||
bool tcp_syn_flood_action(struct sock *sk,
|
||||
const struct sk_buff *skb,
|
||||
const char *proto)
|
||||
{
|
||||
const char *msg = "Dropping request";
|
||||
int want_cookie = 0;
|
||||
bool want_cookie = false;
|
||||
struct listen_sock *lopt;
|
||||
|
||||
|
||||
@@ -881,7 +881,7 @@ int tcp_syn_flood_action(struct sock *sk,
|
||||
#ifdef CONFIG_SYN_COOKIES
|
||||
if (sysctl_tcp_syncookies) {
|
||||
msg = "Sending cookies";
|
||||
want_cookie = 1;
|
||||
want_cookie = true;
|
||||
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_TCPREQQFULLDOCOOKIES);
|
||||
} else
|
||||
#endif
|
||||
@@ -1196,7 +1196,7 @@ clear_hash_noput:
|
||||
}
|
||||
EXPORT_SYMBOL(tcp_v4_md5_hash_skb);
|
||||
|
||||
static int tcp_v4_inbound_md5_hash(struct sock *sk, const struct sk_buff *skb)
|
||||
static bool tcp_v4_inbound_md5_hash(struct sock *sk, const struct sk_buff *skb)
|
||||
{
|
||||
/*
|
||||
* This gets called for each TCP segment that arrives
|
||||
@@ -1219,16 +1219,16 @@ static int tcp_v4_inbound_md5_hash(struct sock *sk, const struct sk_buff *skb)
|
||||
|
||||
/* We've parsed the options - do we have a hash? */
|
||||
if (!hash_expected && !hash_location)
|
||||
return 0;
|
||||
return false;
|
||||
|
||||
if (hash_expected && !hash_location) {
|
||||
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_TCPMD5NOTFOUND);
|
||||
return 1;
|
||||
return true;
|
||||
}
|
||||
|
||||
if (!hash_expected && hash_location) {
|
||||
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_TCPMD5UNEXPECTED);
|
||||
return 1;
|
||||
return true;
|
||||
}
|
||||
|
||||
/* Okay, so this is hash_expected and hash_location -
|
||||
@@ -1244,9 +1244,9 @@ static int tcp_v4_inbound_md5_hash(struct sock *sk, const struct sk_buff *skb)
|
||||
&iph->daddr, ntohs(th->dest),
|
||||
genhash ? " tcp_v4_calc_md5_hash failed"
|
||||
: "");
|
||||
return 1;
|
||||
return true;
|
||||
}
|
||||
return 0;
|
||||
return false;
|
||||
}
|
||||
|
||||
#endif
|
||||
@@ -1280,7 +1280,7 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
|
||||
__be32 saddr = ip_hdr(skb)->saddr;
|
||||
__be32 daddr = ip_hdr(skb)->daddr;
|
||||
__u32 isn = TCP_SKB_CB(skb)->when;
|
||||
int want_cookie = 0;
|
||||
bool want_cookie = false;
|
||||
|
||||
/* Never answer to SYNs send to broadcast or multicast */
|
||||
if (skb_rtable(skb)->rt_flags & (RTCF_BROADCAST | RTCF_MULTICAST))
|
||||
@@ -1339,7 +1339,7 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
|
||||
while (l-- > 0)
|
||||
*c++ ^= *hash_location++;
|
||||
|
||||
want_cookie = 0; /* not our kind of cookie */
|
||||
want_cookie = false; /* not our kind of cookie */
|
||||
tmp_ext.cookie_out_never = 0; /* false */
|
||||
tmp_ext.cookie_plus = tmp_opt.cookie_plus;
|
||||
} else if (!tp->rx_opt.cookie_in_always) {
|
||||
@@ -2073,7 +2073,7 @@ static void *listening_get_idx(struct seq_file *seq, loff_t *pos)
|
||||
return rc;
|
||||
}
|
||||
|
||||
static inline int empty_bucket(struct tcp_iter_state *st)
|
||||
static inline bool empty_bucket(struct tcp_iter_state *st)
|
||||
{
|
||||
return hlist_nulls_empty(&tcp_hashinfo.ehash[st->bucket].chain) &&
|
||||
hlist_nulls_empty(&tcp_hashinfo.ehash[st->bucket].twchain);
|
||||
|
Reference in New Issue
Block a user