NFSD: Rename boot verifier functions
[ Upstream commit 3988a57885eeac05ef89f0ab4d7e47b52fbcf630 ] Clean up: These functions handle what the specs call a write verifier, which in the Linux NFS server implementation is now divorced from the server's boot instance [ cel: adjusted to apply to v5.10.y ] Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
e49677ff33
commit
a1c9bcfd16
@@ -243,7 +243,7 @@ nfsd_file_do_unhash(struct nfsd_file *nf)
|
|||||||
trace_nfsd_file_unhash(nf);
|
trace_nfsd_file_unhash(nf);
|
||||||
|
|
||||||
if (nfsd_file_check_write_error(nf))
|
if (nfsd_file_check_write_error(nf))
|
||||||
nfsd_reset_boot_verifier(net_generic(nf->nf_net, nfsd_net_id));
|
nfsd_reset_write_verifier(net_generic(nf->nf_net, nfsd_net_id));
|
||||||
--nfsd_file_hashtbl[nf->nf_hashval].nfb_count;
|
--nfsd_file_hashtbl[nf->nf_hashval].nfb_count;
|
||||||
hlist_del_rcu(&nf->nf_node);
|
hlist_del_rcu(&nf->nf_node);
|
||||||
atomic_long_dec(&nfsd_filecache_count);
|
atomic_long_dec(&nfsd_filecache_count);
|
||||||
|
@@ -198,6 +198,6 @@ extern void nfsd_netns_free_versions(struct nfsd_net *nn);
|
|||||||
|
|
||||||
extern unsigned int nfsd_net_id;
|
extern unsigned int nfsd_net_id;
|
||||||
|
|
||||||
void nfsd_copy_boot_verifier(__be32 verf[2], struct nfsd_net *nn);
|
void nfsd_copy_write_verifier(__be32 verf[2], struct nfsd_net *nn);
|
||||||
void nfsd_reset_boot_verifier(struct nfsd_net *nn);
|
void nfsd_reset_write_verifier(struct nfsd_net *nn);
|
||||||
#endif /* __NFSD_NETNS_H__ */
|
#endif /* __NFSD_NETNS_H__ */
|
||||||
|
@@ -598,7 +598,7 @@ static void gen_boot_verifier(nfs4_verifier *verifier, struct net *net)
|
|||||||
|
|
||||||
BUILD_BUG_ON(2*sizeof(*verf) != sizeof(verifier->data));
|
BUILD_BUG_ON(2*sizeof(*verf) != sizeof(verifier->data));
|
||||||
|
|
||||||
nfsd_copy_boot_verifier(verf, net_generic(net, nfsd_net_id));
|
nfsd_copy_write_verifier(verf, net_generic(net, nfsd_net_id));
|
||||||
}
|
}
|
||||||
|
|
||||||
static __be32
|
static __be32
|
||||||
|
@@ -346,14 +346,14 @@ static bool nfsd_needs_lockd(struct nfsd_net *nn)
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* nfsd_copy_boot_verifier - Atomically copy a write verifier
|
* nfsd_copy_write_verifier - Atomically copy a write verifier
|
||||||
* @verf: buffer in which to receive the verifier cookie
|
* @verf: buffer in which to receive the verifier cookie
|
||||||
* @nn: NFS net namespace
|
* @nn: NFS net namespace
|
||||||
*
|
*
|
||||||
* This function provides a wait-free mechanism for copying the
|
* This function provides a wait-free mechanism for copying the
|
||||||
* namespace's boot verifier without tearing it.
|
* namespace's write verifier without tearing it.
|
||||||
*/
|
*/
|
||||||
void nfsd_copy_boot_verifier(__be32 verf[2], struct nfsd_net *nn)
|
void nfsd_copy_write_verifier(__be32 verf[2], struct nfsd_net *nn)
|
||||||
{
|
{
|
||||||
int seq = 0;
|
int seq = 0;
|
||||||
|
|
||||||
@@ -364,7 +364,7 @@ void nfsd_copy_boot_verifier(__be32 verf[2], struct nfsd_net *nn)
|
|||||||
done_seqretry(&nn->writeverf_lock, seq);
|
done_seqretry(&nn->writeverf_lock, seq);
|
||||||
}
|
}
|
||||||
|
|
||||||
static void nfsd_reset_boot_verifier_locked(struct nfsd_net *nn)
|
static void nfsd_reset_write_verifier_locked(struct nfsd_net *nn)
|
||||||
{
|
{
|
||||||
struct timespec64 now;
|
struct timespec64 now;
|
||||||
u64 verf;
|
u64 verf;
|
||||||
@@ -379,7 +379,7 @@ static void nfsd_reset_boot_verifier_locked(struct nfsd_net *nn)
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* nfsd_reset_boot_verifier - Generate a new boot verifier
|
* nfsd_reset_write_verifier - Generate a new write verifier
|
||||||
* @nn: NFS net namespace
|
* @nn: NFS net namespace
|
||||||
*
|
*
|
||||||
* This function updates the ->writeverf field of @nn. This field
|
* This function updates the ->writeverf field of @nn. This field
|
||||||
@@ -391,10 +391,10 @@ static void nfsd_reset_boot_verifier_locked(struct nfsd_net *nn)
|
|||||||
* server and MUST be unique between instances of the NFSv4.1
|
* server and MUST be unique between instances of the NFSv4.1
|
||||||
* server."
|
* server."
|
||||||
*/
|
*/
|
||||||
void nfsd_reset_boot_verifier(struct nfsd_net *nn)
|
void nfsd_reset_write_verifier(struct nfsd_net *nn)
|
||||||
{
|
{
|
||||||
write_seqlock(&nn->writeverf_lock);
|
write_seqlock(&nn->writeverf_lock);
|
||||||
nfsd_reset_boot_verifier_locked(nn);
|
nfsd_reset_write_verifier_locked(nn);
|
||||||
write_sequnlock(&nn->writeverf_lock);
|
write_sequnlock(&nn->writeverf_lock);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -683,7 +683,7 @@ int nfsd_create_serv(struct net *net)
|
|||||||
register_inet6addr_notifier(&nfsd_inet6addr_notifier);
|
register_inet6addr_notifier(&nfsd_inet6addr_notifier);
|
||||||
#endif
|
#endif
|
||||||
}
|
}
|
||||||
nfsd_reset_boot_verifier(nn);
|
nfsd_reset_write_verifier(nn);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -572,8 +572,8 @@ __be32 nfsd4_clone_file_range(struct svc_rqst *rqstp,
|
|||||||
&nfsd4_get_cstate(rqstp)->current_fh,
|
&nfsd4_get_cstate(rqstp)->current_fh,
|
||||||
dst_pos,
|
dst_pos,
|
||||||
count, status);
|
count, status);
|
||||||
nfsd_reset_boot_verifier(net_generic(nf_dst->nf_net,
|
nfsd_reset_write_verifier(net_generic(nf_dst->nf_net,
|
||||||
nfsd_net_id));
|
nfsd_net_id));
|
||||||
ret = nfserrno(status);
|
ret = nfserrno(status);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1039,10 +1039,10 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct nfsd_file *nf,
|
|||||||
iov_iter_kvec(&iter, WRITE, vec, vlen, *cnt);
|
iov_iter_kvec(&iter, WRITE, vec, vlen, *cnt);
|
||||||
since = READ_ONCE(file->f_wb_err);
|
since = READ_ONCE(file->f_wb_err);
|
||||||
if (verf)
|
if (verf)
|
||||||
nfsd_copy_boot_verifier(verf, nn);
|
nfsd_copy_write_verifier(verf, nn);
|
||||||
host_err = vfs_iter_write(file, &iter, &pos, flags);
|
host_err = vfs_iter_write(file, &iter, &pos, flags);
|
||||||
if (host_err < 0) {
|
if (host_err < 0) {
|
||||||
nfsd_reset_boot_verifier(nn);
|
nfsd_reset_write_verifier(nn);
|
||||||
goto out_nfserr;
|
goto out_nfserr;
|
||||||
}
|
}
|
||||||
*cnt = host_err;
|
*cnt = host_err;
|
||||||
@@ -1055,7 +1055,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct nfsd_file *nf,
|
|||||||
if (stable && use_wgather) {
|
if (stable && use_wgather) {
|
||||||
host_err = wait_for_concurrent_writes(file);
|
host_err = wait_for_concurrent_writes(file);
|
||||||
if (host_err < 0)
|
if (host_err < 0)
|
||||||
nfsd_reset_boot_verifier(nn);
|
nfsd_reset_write_verifier(nn);
|
||||||
}
|
}
|
||||||
|
|
||||||
out_nfserr:
|
out_nfserr:
|
||||||
@@ -1168,7 +1168,7 @@ nfsd_commit(struct svc_rqst *rqstp, struct svc_fh *fhp,
|
|||||||
err2 = vfs_fsync_range(nf->nf_file, offset, end, 0);
|
err2 = vfs_fsync_range(nf->nf_file, offset, end, 0);
|
||||||
switch (err2) {
|
switch (err2) {
|
||||||
case 0:
|
case 0:
|
||||||
nfsd_copy_boot_verifier(verf, nn);
|
nfsd_copy_write_verifier(verf, nn);
|
||||||
err2 = filemap_check_wb_err(nf->nf_file->f_mapping,
|
err2 = filemap_check_wb_err(nf->nf_file->f_mapping,
|
||||||
since);
|
since);
|
||||||
err = nfserrno(err2);
|
err = nfserrno(err2);
|
||||||
@@ -1177,11 +1177,11 @@ nfsd_commit(struct svc_rqst *rqstp, struct svc_fh *fhp,
|
|||||||
err = nfserr_notsupp;
|
err = nfserr_notsupp;
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
nfsd_reset_boot_verifier(nn);
|
nfsd_reset_write_verifier(nn);
|
||||||
err = nfserrno(err2);
|
err = nfserrno(err2);
|
||||||
}
|
}
|
||||||
} else
|
} else
|
||||||
nfsd_copy_boot_verifier(verf, nn);
|
nfsd_copy_write_verifier(verf, nn);
|
||||||
|
|
||||||
nfsd_file_put(nf);
|
nfsd_file_put(nf);
|
||||||
out:
|
out:
|
||||||
|
Reference in New Issue
Block a user