xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

soc/tegra: Don't leak device tree node reference

Browse Source 
of_find_node_by_path() acquires a reference to the node returned by it
and that reference needs to be dropped by its caller. soc_is_tegra()
doesn't do that, so fix it.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
[treding: slightly rewrite to avoid inline comparison]
Signed-off-by: Thierry Reding <treding@nvidia.com>
This commit is contained in:
Yangtao Li
2018-11-21 07:49:12 -05:00
committed by Thierry Reding
parent 1866d58be7
commit 9eb40fa2cd
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/soc/tegra/common.c
View File

@@ -22,11 +22,15 @@ static const struct of_device_id tegra_machine_match[] = {
bool soc_is_tegra(void) bool soc_is_tegra(void)
{ {
const struct of_device_id *match;
struct device_node *root; struct device_node *root;
root = of_find_node_by_path("/"); root = of_find_node_by_path("/");
if (!root) if (!root)
return false; return false;
return of_match_node(tegra_machine_match, root) != NULL; match = of_match_node(tegra_machine_match, root);
of_node_put(root);
return match != NULL;
} }