drm/ttm: move ttm binding/unbinding out of ttm_tt paths.
Move these up to the bo level, moving ttm_tt to just being backing store. Next step is to move the bound flag out. Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200915024007.67163-6-airlied@gmail.com
This commit is contained in:
@@ -264,7 +264,7 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo,
|
||||
if (ret)
|
||||
goto out_err;
|
||||
|
||||
ret = ttm_tt_bind(bdev, bo->ttm, mem);
|
||||
ret = ttm_bo_tt_bind(bo, mem);
|
||||
if (ret)
|
||||
goto out_err;
|
||||
}
|
||||
@@ -1619,6 +1619,35 @@ void ttm_bo_tt_destroy(struct ttm_buffer_object *bo)
|
||||
{
|
||||
if (bo->ttm == NULL)
|
||||
return;
|
||||
|
||||
ttm_bo_tt_unbind(bo);
|
||||
ttm_tt_destroy(bo->bdev, bo->ttm);
|
||||
bo->ttm = NULL;
|
||||
}
|
||||
|
||||
int ttm_bo_tt_bind(struct ttm_buffer_object *bo, struct ttm_resource *mem)
|
||||
{
|
||||
int ret;
|
||||
|
||||
if (!bo->ttm)
|
||||
return -EINVAL;
|
||||
|
||||
if (ttm_bo_tt_is_bound(bo))
|
||||
return 0;
|
||||
|
||||
ret = bo->bdev->driver->ttm_tt_bind(bo->bdev, bo->ttm, mem);
|
||||
if (unlikely(ret != 0))
|
||||
return ret;
|
||||
|
||||
ttm_bo_tt_set_bound(bo);
|
||||
return 0;
|
||||
}
|
||||
EXPORT_SYMBOL(ttm_bo_tt_bind);
|
||||
|
||||
void ttm_bo_tt_unbind(struct ttm_buffer_object *bo)
|
||||
{
|
||||
if (ttm_bo_tt_is_bound(bo)) {
|
||||
bo->bdev->driver->ttm_tt_unbind(bo->bdev, bo->ttm);
|
||||
ttm_bo_tt_set_unbound(bo);
|
||||
}
|
||||
}
|
||||
|
@@ -67,7 +67,7 @@ int ttm_bo_move_ttm(struct ttm_buffer_object *bo,
|
||||
return ret;
|
||||
}
|
||||
|
||||
ttm_tt_unbind(bo->bdev, ttm);
|
||||
ttm_bo_tt_unbind(bo);
|
||||
ttm_bo_free_old_node(bo);
|
||||
old_mem->mem_type = TTM_PL_SYSTEM;
|
||||
}
|
||||
@@ -82,7 +82,7 @@ int ttm_bo_move_ttm(struct ttm_buffer_object *bo,
|
||||
if (unlikely(ret != 0))
|
||||
return ret;
|
||||
|
||||
ret = ttm_tt_bind(bo->bdev, ttm, new_mem);
|
||||
ret = ttm_bo_tt_bind(bo, new_mem);
|
||||
if (unlikely(ret != 0))
|
||||
return ret;
|
||||
}
|
||||
@@ -701,4 +701,3 @@ int ttm_bo_pipeline_gutting(struct ttm_buffer_object *bo)
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@@ -209,8 +209,6 @@ EXPORT_SYMBOL(ttm_tt_set_placement_caching);
|
||||
|
||||
void ttm_tt_destroy(struct ttm_bo_device *bdev, struct ttm_tt *ttm)
|
||||
{
|
||||
ttm_tt_unbind(bdev, ttm);
|
||||
|
||||
ttm_tt_unpopulate(bdev, ttm);
|
||||
|
||||
if (!(ttm->page_flags & TTM_PAGE_FLAG_PERSISTENT_SWAP) &&
|
||||
@@ -303,35 +301,6 @@ void ttm_dma_tt_fini(struct ttm_dma_tt *ttm_dma)
|
||||
}
|
||||
EXPORT_SYMBOL(ttm_dma_tt_fini);
|
||||
|
||||
void ttm_tt_unbind(struct ttm_bo_device *bdev, struct ttm_tt *ttm)
|
||||
{
|
||||
if (ttm_tt_is_bound(ttm)) {
|
||||
bdev->driver->ttm_tt_unbind(bdev, ttm);
|
||||
ttm_tt_set_unbound(ttm);
|
||||
}
|
||||
}
|
||||
|
||||
int ttm_tt_bind(struct ttm_bo_device *bdev,
|
||||
struct ttm_tt *ttm, struct ttm_resource *bo_mem)
|
||||
{
|
||||
int ret = 0;
|
||||
|
||||
if (!ttm)
|
||||
return -EINVAL;
|
||||
|
||||
if (ttm_tt_is_bound(ttm))
|
||||
return 0;
|
||||
|
||||
ret = bdev->driver->ttm_tt_bind(bdev, ttm, bo_mem);
|
||||
if (unlikely(ret != 0))
|
||||
return ret;
|
||||
|
||||
ttm_tt_set_bound(ttm);
|
||||
|
||||
return 0;
|
||||
}
|
||||
EXPORT_SYMBOL(ttm_tt_bind);
|
||||
|
||||
int ttm_tt_swapin(struct ttm_tt *ttm)
|
||||
{
|
||||
struct address_space *swap_space;
|
||||
|
Reference in New Issue
Block a user