scsi: use external buffer for command logging
Use an external buffer for __scsi_print_command() and move command logging over to use the per-cpu logging buffer. With that we can guarantee the command always will always be formatted in one line. So we can even print out a variable length command correctly across several lines. Finally rename __scsi_print_command() to __scsi_format_comment() to better reflect the functionality. Tested-by: Robert Elliott <elliott@hp.com> Reviewed-by: Robert Elliott <elliott@hp.com> Signed-off-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:

committed by
Christoph Hellwig

parent
aa66ab35f2
commit
9e5ed2a5b3
@@ -5,8 +5,12 @@ struct scsi_cmnd;
|
||||
struct scsi_device;
|
||||
struct scsi_sense_hdr;
|
||||
|
||||
#define SCSI_LOG_BUFSIZE 128
|
||||
|
||||
extern bool scsi_opcode_sa_name(int, int, const char **, const char **);
|
||||
extern void scsi_print_command(struct scsi_cmnd *);
|
||||
extern void __scsi_print_command(const unsigned char *, size_t);
|
||||
extern size_t __scsi_format_command(char *, size_t,
|
||||
const unsigned char *, size_t);
|
||||
extern void scsi_show_extd_sense(const struct scsi_device *, const char *,
|
||||
unsigned char, unsigned char);
|
||||
extern void scsi_show_sense_hdr(const struct scsi_device *, const char *,
|
||||
|
Reference in New Issue
Block a user