x86/fpu: Remove error return values from copy_kernel_to_*regs() functions
None of the copy_kernel_to_*regs() FPU register copying functions are supposed to fail, and all of them have debugging checks that enforce this. Remove their return values and simplify their call sites, which have redundant error checks and error handling code paths. Cc: Andy Lutomirski <luto@amacapital.net> Cc: Bobby Powers <bobbypowers@gmail.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: Fenghua Yu <fenghua.yu@intel.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
@@ -126,12 +126,10 @@ void __kernel_fpu_end(void)
|
||||
{
|
||||
struct fpu *fpu = ¤t->thread.fpu;
|
||||
|
||||
if (fpu->fpregs_active) {
|
||||
if (WARN_ON_FPU(copy_kernel_to_fpregs(fpu)))
|
||||
fpu__clear(fpu);
|
||||
} else {
|
||||
if (fpu->fpregs_active)
|
||||
copy_kernel_to_fpregs(fpu);
|
||||
else
|
||||
__fpregs_deactivate_hw();
|
||||
}
|
||||
|
||||
kernel_fpu_enable();
|
||||
}
|
||||
@@ -370,14 +368,8 @@ void fpu__restore(struct fpu *fpu)
|
||||
/* Avoid __kernel_fpu_begin() right after fpregs_activate() */
|
||||
kernel_fpu_disable();
|
||||
fpregs_activate(fpu);
|
||||
if (unlikely(copy_kernel_to_fpregs(fpu))) {
|
||||
/* Copying the kernel state to FPU registers should never fail: */
|
||||
WARN_ON_FPU(1);
|
||||
fpu__clear(fpu);
|
||||
force_sig_info(SIGSEGV, SEND_SIG_PRIV, current);
|
||||
} else {
|
||||
fpu->counter++;
|
||||
}
|
||||
copy_kernel_to_fpregs(fpu);
|
||||
fpu->counter++;
|
||||
kernel_fpu_enable();
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(fpu__restore);
|
||||
|
Reference in New Issue
Block a user