xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

GRU Driver V3: fixes to resolve code review comments

Browse Source 
Fixes problems identified in a code review:
	- add comment with high level dscription of the GRU
	- prepend "gru_" to all global names
	- delete unused function
	- couple of trivial bug fixes

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Jack Steiner <steiner@sgi.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jack Steiner
2008-07-29 22:34:02 -07:00
committed by Linus Torvalds
parent 3d919e5f6b
commit 9ca8e40c13
7 changed files with 93 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/misc/sgi-gru/gru_instructions.h
View File

@@ -284,16 +284,6 @@ __opword(unsigned char opcode, unsigned char exopc, unsigned char xtype,
(exopc << GRU_CB_EXOPC_SHFT);
}
/*
* Prefetch a cacheline. Fetch is unconditional. Must page fault if
* no valid TLB entry is found.
* ??? should I use actual "load" or hardware prefetch???
*/
static inline void gru_prefetch(void *p)
{
*(volatile char *)p;
}
/*
* Architecture specific intrinsics
*/