PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // <smpl> @@ identifier i; declarer name DEFINE_PCI_DEVICE_TABLE; initializer z; @@ - DEFINE_PCI_DEVICE_TABLE(i) + const struct pci_device_id i[] = z; // </smpl> [bhelgaas: add semantic patch] Signed-off-by: Benoit Taine <benoit.taine@lip6.fr> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:

committed by
Bjorn Helgaas

parent
c8d6637d04
commit
9baa3c34ac
@@ -208,7 +208,7 @@ MODULE_PARM_DESC(use_io, "Force use of i/o access mode");
|
||||
#define INTEL_8255X_ETHERNET_DEVICE(device_id, ich) {\
|
||||
PCI_VENDOR_ID_INTEL, device_id, PCI_ANY_ID, PCI_ANY_ID, \
|
||||
PCI_CLASS_NETWORK_ETHERNET << 8, 0xFFFF00, ich }
|
||||
static DEFINE_PCI_DEVICE_TABLE(e100_id_table) = {
|
||||
static const struct pci_device_id e100_id_table[] = {
|
||||
INTEL_8255X_ETHERNET_DEVICE(0x1029, 0),
|
||||
INTEL_8255X_ETHERNET_DEVICE(0x1030, 0),
|
||||
INTEL_8255X_ETHERNET_DEVICE(0x1031, 3),
|
||||
|
Reference in New Issue
Block a user