net/mlx5: Store flow counters in a list
In order to improve performance of flow counter stats query loop that traverses all configured flow counters, replace rb_tree with double-linked list. This change improves performance of traversing flow counters by removing the tree traversal. (profiling data showed that call to rb_next was most top CPU consumer) However, lookup of flow flow counter in list becomes linear, instead of logarithmic. This problem is fixed by next patch in series, which adds idr for fast lookup. Idr is to be used because it is not an intrusive data structure and doesn't require adding any new members to struct mlx5_fc, which allows its control data part to stay <= 1 cache line in size. Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Acked-by: Amir Vadai <amir@vadai.me> Reviewed-by: Paul Blakey <paulb@mellanox.com> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
This commit is contained in:

committed by
Saeed Mahameed

parent
6e5e228391
commit
9aff93d7d0
@@ -583,7 +583,7 @@ struct mlx5_irq_info {
|
||||
};
|
||||
|
||||
struct mlx5_fc_stats {
|
||||
struct rb_root counters;
|
||||
struct list_head counters;
|
||||
struct llist_head addlist;
|
||||
struct llist_head dellist;
|
||||
|
||||
|
Reference in New Issue
Block a user