RDMA: Simplify get firmware interface
There is a need to forward FW version to user space application through RDMA netlink. In order to make it safe, there is need to declare nla_policy and limit the size of FW string. The new define IB_FW_VERSION_NAME_MAX will limit the size of FW version string. That define was chosen to be equal to ETHTOOL_FWVERS_LEN, because many drivers anyway are limited by that value indirectly. The introduction of this define allows us to remove the string size from get_fw_str function signature. Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Šī revīzija ir iekļauta:

revīziju iesūtīja
Leon Romanovsky

vecāks
ac50525374
revīzija
9abb0d1bbd
@@ -107,12 +107,11 @@ static int ocrdma_port_immutable(struct ib_device *ibdev, u8 port_num,
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void get_dev_fw_str(struct ib_device *device, char *str,
|
||||
size_t str_len)
|
||||
static void get_dev_fw_str(struct ib_device *device, char *str)
|
||||
{
|
||||
struct ocrdma_dev *dev = get_ocrdma_dev(device);
|
||||
|
||||
snprintf(str, str_len, "%s", &dev->attr.fw_ver[0]);
|
||||
snprintf(str, IB_FW_VERSION_NAME_MAX, "%s", &dev->attr.fw_ver[0]);
|
||||
}
|
||||
|
||||
static int ocrdma_register_device(struct ocrdma_dev *dev)
|
||||
|
Atsaukties uz šo jaunā problēmā
Block a user