Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
Pull networking updates from David Miller: "Highlights: - Gustavo A. R. Silva keeps working on the implicit switch fallthru changes. - Support 802.11ax High-Efficiency wireless in cfg80211 et al, From Luca Coelho. - Re-enable ASPM in r8169, from Kai-Heng Feng. - Add virtual XFRM interfaces, which avoids all of the limitations of existing IPSEC tunnels. From Steffen Klassert. - Convert GRO over to use a hash table, so that when we have many flows active we don't traverse a long list during accumluation. - Many new self tests for routing, TC, tunnels, etc. Too many contributors to mention them all, but I'm really happy to keep seeing this stuff. - Hardware timestamping support for dpaa_eth/fsl-fman from Yangbo Lu. - Lots of cleanups and fixes in L2TP code from Guillaume Nault. - Add IPSEC offload support to netdevsim, from Shannon Nelson. - Add support for slotting with non-uniform distribution to netem packet scheduler, from Yousuk Seung. - Add UDP GSO support to mlx5e, from Boris Pismenny. - Support offloading of Team LAG in NFP, from John Hurley. - Allow to configure TX queue selection based upon RX queue, from Amritha Nambiar. - Support ethtool ring size configuration in aquantia, from Anton Mikaev. - Support DSCP and flowlabel per-transport in SCTP, from Xin Long. - Support list based batching and stack traversal of SKBs, this is very exciting work. From Edward Cree. - Busyloop optimizations in vhost_net, from Toshiaki Makita. - Introduce the ETF qdisc, which allows time based transmissions. IGB can offload this in hardware. From Vinicius Costa Gomes. - Add parameter support to devlink, from Moshe Shemesh. - Several multiplication and division optimizations for BPF JIT in nfp driver, from Jiong Wang. - Lots of prepatory work to make more of the packet scheduler layer lockless, when possible, from Vlad Buslov. - Add ACK filter and NAT awareness to sch_cake packet scheduler, from Toke Høiland-Jørgensen. - Support regions and region snapshots in devlink, from Alex Vesker. - Allow to attach XDP programs to both HW and SW at the same time on a given device, with initial support in nfp. From Jakub Kicinski. - Add TLS RX offload and support in mlx5, from Ilya Lesokhin. - Use PHYLIB in r8169 driver, from Heiner Kallweit. - All sorts of changes to support Spectrum 2 in mlxsw driver, from Ido Schimmel. - PTP support in mv88e6xxx DSA driver, from Andrew Lunn. - Make TCP_USER_TIMEOUT socket option more accurate, from Jon Maxwell. - Support for templates in packet scheduler classifier, from Jiri Pirko. - IPV6 support in RDS, from Ka-Cheong Poon. - Native tproxy support in nf_tables, from Máté Eckl. - Maintain IP fragment queue in an rbtree, but optimize properly for in-order frags. From Peter Oskolkov. - Improvde handling of ACKs on hole repairs, from Yuchung Cheng" * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next: (1996 commits) bpf: test: fix spelling mistake "REUSEEPORT" -> "REUSEPORT" hv/netvsc: Fix NULL dereference at single queue mode fallback net: filter: mark expected switch fall-through xen-netfront: fix warn message as irq device name has '/' cxgb4: Add new T5 PCI device ids 0x50af and 0x50b0 net: dsa: mv88e6xxx: missing unlock on error path rds: fix building with IPV6=m inet/connection_sock: prefer _THIS_IP_ to current_text_addr net: dsa: mv88e6xxx: bitwise vs logical bug net: sock_diag: Fix spectre v1 gadget in __sock_diag_cmd() ieee802154: hwsim: using right kind of iteration net: hns3: Add vlan filter setting by ethtool command -K net: hns3: Set tx ring' tc info when netdev is up net: hns3: Remove tx ring BD len register in hns3_enet net: hns3: Fix desc num set to default when setting channel net: hns3: Fix for phy link issue when using marvell phy driver net: hns3: Fix for information of phydev lost problem when down/up net: hns3: Fix for command format parsing error in hclge_is_all_function_id_zero net: hns3: Add support for serdes loopback selftest bnxt_en: take coredump_record structure off stack ...
This commit is contained in:
@@ -741,7 +741,7 @@ static __poll_t rxrpc_poll(struct file *file, struct socket *sock,
|
||||
struct rxrpc_sock *rx = rxrpc_sk(sk);
|
||||
__poll_t mask;
|
||||
|
||||
sock_poll_wait(file, sk_sleep(sk), wait);
|
||||
sock_poll_wait(file, wait);
|
||||
mask = 0;
|
||||
|
||||
/* the socket is readable if there are any messages waiting on the Rx
|
||||
|
@@ -420,6 +420,7 @@ struct rxrpc_connection {
|
||||
struct rxrpc_channel {
|
||||
unsigned long final_ack_at; /* Time at which to issue final ACK */
|
||||
struct rxrpc_call __rcu *call; /* Active call */
|
||||
unsigned int call_debug_id; /* call->debug_id */
|
||||
u32 call_id; /* ID of current call */
|
||||
u32 call_counter; /* Call ID counter */
|
||||
u32 last_call; /* ID of last call */
|
||||
@@ -478,6 +479,7 @@ enum rxrpc_call_flag {
|
||||
RXRPC_CALL_RETRANS_TIMEOUT, /* Retransmission due to timeout occurred */
|
||||
RXRPC_CALL_BEGAN_RX_TIMER, /* We began the expect_rx_by timer */
|
||||
RXRPC_CALL_RX_HEARD, /* The peer responded at least once to this call */
|
||||
RXRPC_CALL_RX_UNDERRUN, /* Got data underrun */
|
||||
};
|
||||
|
||||
/*
|
||||
@@ -588,7 +590,7 @@ struct rxrpc_call {
|
||||
*/
|
||||
#define RXRPC_RXTX_BUFF_SIZE 64
|
||||
#define RXRPC_RXTX_BUFF_MASK (RXRPC_RXTX_BUFF_SIZE - 1)
|
||||
#define RXRPC_INIT_RX_WINDOW_SIZE 32
|
||||
#define RXRPC_INIT_RX_WINDOW_SIZE 63
|
||||
struct sk_buff **rxtx_buffer;
|
||||
u8 *rxtx_annotations;
|
||||
#define RXRPC_TX_ANNO_ACK 0
|
||||
|
@@ -162,7 +162,6 @@ static void rxrpc_congestion_timeout(struct rxrpc_call *call)
|
||||
*/
|
||||
static void rxrpc_resend(struct rxrpc_call *call, unsigned long now_j)
|
||||
{
|
||||
struct rxrpc_skb_priv *sp;
|
||||
struct sk_buff *skb;
|
||||
unsigned long resend_at;
|
||||
rxrpc_seq_t cursor, seq, top;
|
||||
@@ -207,7 +206,6 @@ static void rxrpc_resend(struct rxrpc_call *call, unsigned long now_j)
|
||||
|
||||
skb = call->rxtx_buffer[ix];
|
||||
rxrpc_see_skb(skb, rxrpc_skb_tx_seen);
|
||||
sp = rxrpc_skb(skb);
|
||||
|
||||
if (anno_type == RXRPC_TX_ANNO_UNACK) {
|
||||
if (ktime_after(skb->tstamp, max_age)) {
|
||||
|
@@ -590,6 +590,7 @@ static void rxrpc_activate_one_channel(struct rxrpc_connection *conn,
|
||||
*/
|
||||
smp_wmb();
|
||||
chan->call_id = call_id;
|
||||
chan->call_debug_id = call->debug_id;
|
||||
rcu_assign_pointer(chan->call, call);
|
||||
wake_up(&call->waitq);
|
||||
}
|
||||
@@ -1051,7 +1052,6 @@ void rxrpc_discard_expired_client_conns(struct work_struct *work)
|
||||
container_of(work, struct rxrpc_net, client_conn_reaper);
|
||||
unsigned long expiry, conn_expires_at, now;
|
||||
unsigned int nr_conns;
|
||||
bool did_discard = false;
|
||||
|
||||
_enter("");
|
||||
|
||||
@@ -1113,7 +1113,6 @@ next:
|
||||
* If someone re-sets the flag and re-gets the ref, that's fine.
|
||||
*/
|
||||
rxrpc_put_connection(conn);
|
||||
did_discard = true;
|
||||
nr_conns--;
|
||||
goto next;
|
||||
|
||||
|
@@ -129,8 +129,10 @@ static void rxrpc_conn_retransmit_call(struct rxrpc_connection *conn,
|
||||
_proto("Tx ABORT %%%u { %d } [re]", serial, conn->local_abort);
|
||||
break;
|
||||
case RXRPC_PACKET_TYPE_ACK:
|
||||
trace_rxrpc_tx_ack(NULL, serial, chan->last_seq, 0,
|
||||
RXRPC_ACK_DUPLICATE, 0);
|
||||
trace_rxrpc_tx_ack(chan->call_debug_id, serial,
|
||||
ntohl(pkt.ack.firstPacket),
|
||||
ntohl(pkt.ack.serial),
|
||||
pkt.ack.reason, 0);
|
||||
_proto("Tx ACK %%%u [re]", serial);
|
||||
break;
|
||||
}
|
||||
@@ -138,8 +140,11 @@ static void rxrpc_conn_retransmit_call(struct rxrpc_connection *conn,
|
||||
ret = kernel_sendmsg(conn->params.local->socket, &msg, iov, ioc, len);
|
||||
conn->params.peer->last_tx_at = ktime_get_seconds();
|
||||
if (ret < 0)
|
||||
trace_rxrpc_tx_fail(conn->debug_id, serial, ret,
|
||||
rxrpc_tx_fail_call_final_resend);
|
||||
trace_rxrpc_tx_fail(chan->call_debug_id, serial, ret,
|
||||
rxrpc_tx_point_call_final_resend);
|
||||
else
|
||||
trace_rxrpc_tx_packet(chan->call_debug_id, &pkt.whdr,
|
||||
rxrpc_tx_point_call_final_resend);
|
||||
|
||||
_leave("");
|
||||
}
|
||||
@@ -240,11 +245,13 @@ static int rxrpc_abort_connection(struct rxrpc_connection *conn,
|
||||
ret = kernel_sendmsg(conn->params.local->socket, &msg, iov, 2, len);
|
||||
if (ret < 0) {
|
||||
trace_rxrpc_tx_fail(conn->debug_id, serial, ret,
|
||||
rxrpc_tx_fail_conn_abort);
|
||||
rxrpc_tx_point_conn_abort);
|
||||
_debug("sendmsg failed: %d", ret);
|
||||
return -EAGAIN;
|
||||
}
|
||||
|
||||
trace_rxrpc_tx_packet(conn->debug_id, &whdr, rxrpc_tx_point_conn_abort);
|
||||
|
||||
conn->params.peer->last_tx_at = ktime_get_seconds();
|
||||
|
||||
_leave(" = 0");
|
||||
|
@@ -496,7 +496,7 @@ next_subpacket:
|
||||
return rxrpc_proto_abort("LSA", call, seq);
|
||||
}
|
||||
|
||||
trace_rxrpc_rx_data(call, seq, serial, flags, annotation);
|
||||
trace_rxrpc_rx_data(call->debug_id, seq, serial, flags, annotation);
|
||||
if (before_eq(seq, hard_ack)) {
|
||||
ack = RXRPC_ACK_DUPLICATE;
|
||||
ack_serial = serial;
|
||||
@@ -592,9 +592,15 @@ ack:
|
||||
rxrpc_propose_ACK(call, ack, skew, ack_serial,
|
||||
immediate_ack, true,
|
||||
rxrpc_propose_ack_input_data);
|
||||
else
|
||||
rxrpc_propose_ACK(call, RXRPC_ACK_DELAY, skew, serial,
|
||||
false, true,
|
||||
rxrpc_propose_ack_input_data);
|
||||
|
||||
if (sp->hdr.seq == READ_ONCE(call->rx_hard_ack) + 1)
|
||||
if (sp->hdr.seq == READ_ONCE(call->rx_hard_ack) + 1) {
|
||||
trace_rxrpc_notify_socket(call->debug_id, serial);
|
||||
rxrpc_notify_socket(call);
|
||||
}
|
||||
_leave(" [queued]");
|
||||
}
|
||||
|
||||
@@ -1262,6 +1268,11 @@ void rxrpc_data_ready(struct sock *udp_sk)
|
||||
/* But otherwise we need to retransmit the final packet
|
||||
* from data cached in the connection record.
|
||||
*/
|
||||
if (sp->hdr.type == RXRPC_PACKET_TYPE_DATA)
|
||||
trace_rxrpc_rx_data(chan->call_debug_id,
|
||||
sp->hdr.seq,
|
||||
sp->hdr.serial,
|
||||
sp->hdr.flags, 0);
|
||||
rxrpc_post_packet_to_conn(conn, skb);
|
||||
goto out_unlock;
|
||||
}
|
||||
|
@@ -72,7 +72,10 @@ static void rxrpc_send_version_request(struct rxrpc_local *local,
|
||||
ret = kernel_sendmsg(local->socket, &msg, iov, 2, len);
|
||||
if (ret < 0)
|
||||
trace_rxrpc_tx_fail(local->debug_id, 0, ret,
|
||||
rxrpc_tx_fail_version_reply);
|
||||
rxrpc_tx_point_version_reply);
|
||||
else
|
||||
trace_rxrpc_tx_packet(local->debug_id, &whdr,
|
||||
rxrpc_tx_point_version_reply);
|
||||
|
||||
_leave("");
|
||||
}
|
||||
|
@@ -183,7 +183,7 @@ int rxrpc_send_ack_packet(struct rxrpc_call *call, bool ping,
|
||||
|
||||
serial = atomic_inc_return(&conn->serial);
|
||||
pkt->whdr.serial = htonl(serial);
|
||||
trace_rxrpc_tx_ack(call, serial,
|
||||
trace_rxrpc_tx_ack(call->debug_id, serial,
|
||||
ntohl(pkt->ack.firstPacket),
|
||||
ntohl(pkt->ack.serial),
|
||||
pkt->ack.reason, pkt->ack.nAcks);
|
||||
@@ -212,7 +212,10 @@ int rxrpc_send_ack_packet(struct rxrpc_call *call, bool ping,
|
||||
conn->params.peer->last_tx_at = ktime_get_seconds();
|
||||
if (ret < 0)
|
||||
trace_rxrpc_tx_fail(call->debug_id, serial, ret,
|
||||
rxrpc_tx_fail_call_ack);
|
||||
rxrpc_tx_point_call_ack);
|
||||
else
|
||||
trace_rxrpc_tx_packet(call->debug_id, &pkt->whdr,
|
||||
rxrpc_tx_point_call_ack);
|
||||
|
||||
if (call->state < RXRPC_CALL_COMPLETE) {
|
||||
if (ret < 0) {
|
||||
@@ -299,7 +302,10 @@ int rxrpc_send_abort_packet(struct rxrpc_call *call)
|
||||
conn->params.peer->last_tx_at = ktime_get_seconds();
|
||||
if (ret < 0)
|
||||
trace_rxrpc_tx_fail(call->debug_id, serial, ret,
|
||||
rxrpc_tx_fail_call_abort);
|
||||
rxrpc_tx_point_call_abort);
|
||||
else
|
||||
trace_rxrpc_tx_packet(call->debug_id, &pkt.whdr,
|
||||
rxrpc_tx_point_call_abort);
|
||||
|
||||
|
||||
rxrpc_put_connection(conn);
|
||||
@@ -396,7 +402,10 @@ int rxrpc_send_data_packet(struct rxrpc_call *call, struct sk_buff *skb,
|
||||
up_read(&conn->params.local->defrag_sem);
|
||||
if (ret < 0)
|
||||
trace_rxrpc_tx_fail(call->debug_id, serial, ret,
|
||||
rxrpc_tx_fail_call_data_nofrag);
|
||||
rxrpc_tx_point_call_data_nofrag);
|
||||
else
|
||||
trace_rxrpc_tx_packet(call->debug_id, &whdr,
|
||||
rxrpc_tx_point_call_data_nofrag);
|
||||
if (ret == -EMSGSIZE)
|
||||
goto send_fragmentable;
|
||||
|
||||
@@ -488,7 +497,10 @@ send_fragmentable:
|
||||
|
||||
if (ret < 0)
|
||||
trace_rxrpc_tx_fail(call->debug_id, serial, ret,
|
||||
rxrpc_tx_fail_call_data_frag);
|
||||
rxrpc_tx_point_call_data_frag);
|
||||
else
|
||||
trace_rxrpc_tx_packet(call->debug_id, &whdr,
|
||||
rxrpc_tx_point_call_data_frag);
|
||||
|
||||
up_write(&conn->params.local->defrag_sem);
|
||||
goto done;
|
||||
@@ -545,7 +557,10 @@ void rxrpc_reject_packets(struct rxrpc_local *local)
|
||||
ret = kernel_sendmsg(local->socket, &msg, iov, 2, size);
|
||||
if (ret < 0)
|
||||
trace_rxrpc_tx_fail(local->debug_id, 0, ret,
|
||||
rxrpc_tx_fail_reject);
|
||||
rxrpc_tx_point_reject);
|
||||
else
|
||||
trace_rxrpc_tx_packet(local->debug_id, &whdr,
|
||||
rxrpc_tx_point_reject);
|
||||
}
|
||||
|
||||
rxrpc_free_skb(skb, rxrpc_skb_rx_freed);
|
||||
@@ -597,7 +612,10 @@ void rxrpc_send_keepalive(struct rxrpc_peer *peer)
|
||||
ret = kernel_sendmsg(peer->local->socket, &msg, iov, 2, len);
|
||||
if (ret < 0)
|
||||
trace_rxrpc_tx_fail(peer->debug_id, 0, ret,
|
||||
rxrpc_tx_fail_version_keepalive);
|
||||
rxrpc_tx_point_version_keepalive);
|
||||
else
|
||||
trace_rxrpc_tx_packet(peer->debug_id, &whdr,
|
||||
rxrpc_tx_point_version_keepalive);
|
||||
|
||||
peer->last_tx_at = ktime_get_seconds();
|
||||
_leave("");
|
||||
|
@@ -63,6 +63,7 @@ static int rxrpc_call_seq_show(struct seq_file *seq, void *v)
|
||||
struct rxrpc_peer *peer;
|
||||
struct rxrpc_call *call;
|
||||
struct rxrpc_net *rxnet = rxrpc_net(seq_file_net(seq));
|
||||
unsigned long timeout = 0;
|
||||
rxrpc_seq_t tx_hard_ack, rx_hard_ack;
|
||||
char lbuff[50], rbuff[50];
|
||||
|
||||
@@ -71,7 +72,7 @@ static int rxrpc_call_seq_show(struct seq_file *seq, void *v)
|
||||
"Proto Local "
|
||||
" Remote "
|
||||
" SvID ConnID CallID End Use State Abort "
|
||||
" UserID\n");
|
||||
" UserID TxSeq TW RxSeq RW RxSerial RxTimo\n");
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -94,11 +95,16 @@ static int rxrpc_call_seq_show(struct seq_file *seq, void *v)
|
||||
else
|
||||
strcpy(rbuff, "no_connection");
|
||||
|
||||
if (call->state != RXRPC_CALL_SERVER_PREALLOC) {
|
||||
timeout = READ_ONCE(call->expect_rx_by);
|
||||
timeout -= jiffies;
|
||||
}
|
||||
|
||||
tx_hard_ack = READ_ONCE(call->tx_hard_ack);
|
||||
rx_hard_ack = READ_ONCE(call->rx_hard_ack);
|
||||
seq_printf(seq,
|
||||
"UDP %-47.47s %-47.47s %4x %08x %08x %s %3u"
|
||||
" %-8.8s %08x %lx %08x %02x %08x %02x\n",
|
||||
" %-8.8s %08x %lx %08x %02x %08x %02x %08x %06lx\n",
|
||||
lbuff,
|
||||
rbuff,
|
||||
call->service_id,
|
||||
@@ -110,7 +116,9 @@ static int rxrpc_call_seq_show(struct seq_file *seq, void *v)
|
||||
call->abort_code,
|
||||
call->user_call_ID,
|
||||
tx_hard_ack, READ_ONCE(call->tx_top) - tx_hard_ack,
|
||||
rx_hard_ack, READ_ONCE(call->rx_top) - rx_hard_ack);
|
||||
rx_hard_ack, READ_ONCE(call->rx_top) - rx_hard_ack,
|
||||
call->rx_serial,
|
||||
timeout);
|
||||
|
||||
return 0;
|
||||
}
|
||||
@@ -179,7 +187,7 @@ static int rxrpc_connection_seq_show(struct seq_file *seq, void *v)
|
||||
print:
|
||||
seq_printf(seq,
|
||||
"UDP %-47.47s %-47.47s %4x %08x %s %3u"
|
||||
" %s %08x %08x %08x\n",
|
||||
" %s %08x %08x %08x %08x %08x %08x %08x\n",
|
||||
lbuff,
|
||||
rbuff,
|
||||
conn->service_id,
|
||||
@@ -189,7 +197,11 @@ print:
|
||||
rxrpc_conn_states[conn->state],
|
||||
key_serial(conn->params.key),
|
||||
atomic_read(&conn->serial),
|
||||
conn->hi_serial);
|
||||
conn->hi_serial,
|
||||
conn->channels[0].call_id,
|
||||
conn->channels[1].call_id,
|
||||
conn->channels[2].call_id,
|
||||
conn->channels[3].call_id);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
@@ -144,13 +144,11 @@ static void rxrpc_end_rx_phase(struct rxrpc_call *call, rxrpc_serial_t serial)
|
||||
trace_rxrpc_receive(call, rxrpc_receive_end, 0, call->rx_top);
|
||||
ASSERTCMP(call->rx_hard_ack, ==, call->rx_top);
|
||||
|
||||
#if 0 // TODO: May want to transmit final ACK under some circumstances anyway
|
||||
if (call->state == RXRPC_CALL_CLIENT_RECV_REPLY) {
|
||||
rxrpc_propose_ACK(call, RXRPC_ACK_IDLE, 0, serial, true, false,
|
||||
rxrpc_propose_ACK(call, RXRPC_ACK_IDLE, 0, serial, false, true,
|
||||
rxrpc_propose_ack_terminal_ack);
|
||||
rxrpc_send_ack_packet(call, false, NULL);
|
||||
//rxrpc_send_ack_packet(call, false, NULL);
|
||||
}
|
||||
#endif
|
||||
|
||||
write_lock_bh(&call->state_lock);
|
||||
|
||||
@@ -315,6 +313,10 @@ static int rxrpc_recvmsg_data(struct socket *sock, struct rxrpc_call *call,
|
||||
unsigned int rx_pkt_offset, rx_pkt_len;
|
||||
int ix, copy, ret = -EAGAIN, ret2;
|
||||
|
||||
if (test_and_clear_bit(RXRPC_CALL_RX_UNDERRUN, &call->flags) &&
|
||||
call->ackr_reason)
|
||||
rxrpc_send_ack_packet(call, false, NULL);
|
||||
|
||||
rx_pkt_offset = call->rx_pkt_offset;
|
||||
rx_pkt_len = call->rx_pkt_len;
|
||||
|
||||
@@ -414,6 +416,8 @@ out:
|
||||
done:
|
||||
trace_rxrpc_recvmsg(call, rxrpc_recvmsg_data_return, seq,
|
||||
rx_pkt_offset, rx_pkt_len, ret);
|
||||
if (ret == -EAGAIN)
|
||||
set_bit(RXRPC_CALL_RX_UNDERRUN, &call->flags);
|
||||
return ret;
|
||||
}
|
||||
|
||||
@@ -607,9 +611,7 @@ wait_error:
|
||||
* rxrpc_kernel_recv_data - Allow a kernel service to receive data/info
|
||||
* @sock: The socket that the call exists on
|
||||
* @call: The call to send data through
|
||||
* @buf: The buffer to receive into
|
||||
* @size: The size of the buffer, including data already read
|
||||
* @_offset: The running offset into the buffer.
|
||||
* @iter: The buffer to receive into
|
||||
* @want_more: True if more data is expected to be read
|
||||
* @_abort: Where the abort code is stored if -ECONNABORTED is returned
|
||||
* @_service: Where to store the actual service ID (may be upgraded)
|
||||
@@ -622,39 +624,30 @@ wait_error:
|
||||
* Note that we may return -EAGAIN to drain empty packets at the end of the
|
||||
* data, even if we've already copied over the requested data.
|
||||
*
|
||||
* This function adds the amount it transfers to *_offset, so this should be
|
||||
* precleared as appropriate. Note that the amount remaining in the buffer is
|
||||
* taken to be size - *_offset.
|
||||
*
|
||||
* *_abort should also be initialised to 0.
|
||||
*/
|
||||
int rxrpc_kernel_recv_data(struct socket *sock, struct rxrpc_call *call,
|
||||
void *buf, size_t size, size_t *_offset,
|
||||
struct iov_iter *iter,
|
||||
bool want_more, u32 *_abort, u16 *_service)
|
||||
{
|
||||
struct iov_iter iter;
|
||||
struct kvec iov;
|
||||
size_t offset = 0;
|
||||
int ret;
|
||||
|
||||
_enter("{%d,%s},%zu/%zu,%d",
|
||||
_enter("{%d,%s},%zu,%d",
|
||||
call->debug_id, rxrpc_call_states[call->state],
|
||||
*_offset, size, want_more);
|
||||
iov_iter_count(iter), want_more);
|
||||
|
||||
ASSERTCMP(*_offset, <=, size);
|
||||
ASSERTCMP(call->state, !=, RXRPC_CALL_SERVER_ACCEPTING);
|
||||
|
||||
iov.iov_base = buf + *_offset;
|
||||
iov.iov_len = size - *_offset;
|
||||
iov_iter_kvec(&iter, ITER_KVEC | READ, &iov, 1, size - *_offset);
|
||||
|
||||
mutex_lock(&call->user_mutex);
|
||||
|
||||
switch (READ_ONCE(call->state)) {
|
||||
case RXRPC_CALL_CLIENT_RECV_REPLY:
|
||||
case RXRPC_CALL_SERVER_RECV_REQUEST:
|
||||
case RXRPC_CALL_SERVER_ACK_REQUEST:
|
||||
ret = rxrpc_recvmsg_data(sock, call, NULL, &iter, size, 0,
|
||||
_offset);
|
||||
ret = rxrpc_recvmsg_data(sock, call, NULL, iter,
|
||||
iov_iter_count(iter), 0,
|
||||
&offset);
|
||||
if (ret < 0)
|
||||
goto out;
|
||||
|
||||
@@ -663,7 +656,7 @@ int rxrpc_kernel_recv_data(struct socket *sock, struct rxrpc_call *call,
|
||||
* full buffer or have been given -EAGAIN.
|
||||
*/
|
||||
if (ret == 1) {
|
||||
if (*_offset < size)
|
||||
if (iov_iter_count(iter) > 0)
|
||||
goto short_data;
|
||||
if (!want_more)
|
||||
goto read_phase_complete;
|
||||
@@ -686,10 +679,21 @@ int rxrpc_kernel_recv_data(struct socket *sock, struct rxrpc_call *call,
|
||||
read_phase_complete:
|
||||
ret = 1;
|
||||
out:
|
||||
switch (call->ackr_reason) {
|
||||
case RXRPC_ACK_IDLE:
|
||||
break;
|
||||
case RXRPC_ACK_DELAY:
|
||||
if (ret != -EAGAIN)
|
||||
break;
|
||||
/* Fall through */
|
||||
default:
|
||||
rxrpc_send_ack_packet(call, false, NULL);
|
||||
}
|
||||
|
||||
if (_service)
|
||||
*_service = call->service_id;
|
||||
mutex_unlock(&call->user_mutex);
|
||||
_leave(" = %d [%zu,%d]", ret, *_offset, *_abort);
|
||||
_leave(" = %d [%zu,%d]", ret, iov_iter_count(iter), *_abort);
|
||||
return ret;
|
||||
|
||||
short_data:
|
||||
@@ -705,7 +709,7 @@ call_complete:
|
||||
ret = call->error;
|
||||
if (call->completion == RXRPC_CALL_SUCCEEDED) {
|
||||
ret = 1;
|
||||
if (size > 0)
|
||||
if (iov_iter_count(iter) > 0)
|
||||
ret = -ECONNRESET;
|
||||
}
|
||||
goto out;
|
||||
|
@@ -146,10 +146,10 @@ static int rxkad_prime_packet_security(struct rxrpc_connection *conn)
|
||||
static int rxkad_secure_packet_auth(const struct rxrpc_call *call,
|
||||
struct sk_buff *skb,
|
||||
u32 data_size,
|
||||
void *sechdr)
|
||||
void *sechdr,
|
||||
struct skcipher_request *req)
|
||||
{
|
||||
struct rxrpc_skb_priv *sp = rxrpc_skb(skb);
|
||||
SKCIPHER_REQUEST_ON_STACK(req, call->conn->cipher);
|
||||
struct rxkad_level1_hdr hdr;
|
||||
struct rxrpc_crypt iv;
|
||||
struct scatterlist sg;
|
||||
@@ -183,12 +183,12 @@ static int rxkad_secure_packet_auth(const struct rxrpc_call *call,
|
||||
static int rxkad_secure_packet_encrypt(const struct rxrpc_call *call,
|
||||
struct sk_buff *skb,
|
||||
u32 data_size,
|
||||
void *sechdr)
|
||||
void *sechdr,
|
||||
struct skcipher_request *req)
|
||||
{
|
||||
const struct rxrpc_key_token *token;
|
||||
struct rxkad_level2_hdr rxkhdr;
|
||||
struct rxrpc_skb_priv *sp;
|
||||
SKCIPHER_REQUEST_ON_STACK(req, call->conn->cipher);
|
||||
struct rxrpc_crypt iv;
|
||||
struct scatterlist sg[16];
|
||||
struct sk_buff *trailer;
|
||||
@@ -296,11 +296,12 @@ static int rxkad_secure_packet(struct rxrpc_call *call,
|
||||
ret = 0;
|
||||
break;
|
||||
case RXRPC_SECURITY_AUTH:
|
||||
ret = rxkad_secure_packet_auth(call, skb, data_size, sechdr);
|
||||
ret = rxkad_secure_packet_auth(call, skb, data_size, sechdr,
|
||||
req);
|
||||
break;
|
||||
case RXRPC_SECURITY_ENCRYPT:
|
||||
ret = rxkad_secure_packet_encrypt(call, skb, data_size,
|
||||
sechdr);
|
||||
sechdr, req);
|
||||
break;
|
||||
default:
|
||||
ret = -EPERM;
|
||||
@@ -316,10 +317,10 @@ static int rxkad_secure_packet(struct rxrpc_call *call,
|
||||
*/
|
||||
static int rxkad_verify_packet_1(struct rxrpc_call *call, struct sk_buff *skb,
|
||||
unsigned int offset, unsigned int len,
|
||||
rxrpc_seq_t seq)
|
||||
rxrpc_seq_t seq,
|
||||
struct skcipher_request *req)
|
||||
{
|
||||
struct rxkad_level1_hdr sechdr;
|
||||
SKCIPHER_REQUEST_ON_STACK(req, call->conn->cipher);
|
||||
struct rxrpc_crypt iv;
|
||||
struct scatterlist sg[16];
|
||||
struct sk_buff *trailer;
|
||||
@@ -402,11 +403,11 @@ nomem:
|
||||
*/
|
||||
static int rxkad_verify_packet_2(struct rxrpc_call *call, struct sk_buff *skb,
|
||||
unsigned int offset, unsigned int len,
|
||||
rxrpc_seq_t seq)
|
||||
rxrpc_seq_t seq,
|
||||
struct skcipher_request *req)
|
||||
{
|
||||
const struct rxrpc_key_token *token;
|
||||
struct rxkad_level2_hdr sechdr;
|
||||
SKCIPHER_REQUEST_ON_STACK(req, call->conn->cipher);
|
||||
struct rxrpc_crypt iv;
|
||||
struct scatterlist _sg[4], *sg;
|
||||
struct sk_buff *trailer;
|
||||
@@ -549,9 +550,9 @@ static int rxkad_verify_packet(struct rxrpc_call *call, struct sk_buff *skb,
|
||||
case RXRPC_SECURITY_PLAIN:
|
||||
return 0;
|
||||
case RXRPC_SECURITY_AUTH:
|
||||
return rxkad_verify_packet_1(call, skb, offset, len, seq);
|
||||
return rxkad_verify_packet_1(call, skb, offset, len, seq, req);
|
||||
case RXRPC_SECURITY_ENCRYPT:
|
||||
return rxkad_verify_packet_2(call, skb, offset, len, seq);
|
||||
return rxkad_verify_packet_2(call, skb, offset, len, seq, req);
|
||||
default:
|
||||
return -ENOANO;
|
||||
}
|
||||
@@ -665,11 +666,13 @@ static int rxkad_issue_challenge(struct rxrpc_connection *conn)
|
||||
ret = kernel_sendmsg(conn->params.local->socket, &msg, iov, 2, len);
|
||||
if (ret < 0) {
|
||||
trace_rxrpc_tx_fail(conn->debug_id, serial, ret,
|
||||
rxrpc_tx_fail_conn_challenge);
|
||||
rxrpc_tx_point_rxkad_challenge);
|
||||
return -EAGAIN;
|
||||
}
|
||||
|
||||
conn->params.peer->last_tx_at = ktime_get_seconds();
|
||||
trace_rxrpc_tx_packet(conn->debug_id, &whdr,
|
||||
rxrpc_tx_point_rxkad_challenge);
|
||||
_leave(" = 0");
|
||||
return 0;
|
||||
}
|
||||
@@ -721,7 +724,7 @@ static int rxkad_send_response(struct rxrpc_connection *conn,
|
||||
ret = kernel_sendmsg(conn->params.local->socket, &msg, iov, 3, len);
|
||||
if (ret < 0) {
|
||||
trace_rxrpc_tx_fail(conn->debug_id, serial, ret,
|
||||
rxrpc_tx_fail_conn_response);
|
||||
rxrpc_tx_point_rxkad_response);
|
||||
return -EAGAIN;
|
||||
}
|
||||
|
||||
|
@@ -15,7 +15,6 @@
|
||||
#include "ar-internal.h"
|
||||
|
||||
static struct ctl_table_header *rxrpc_sysctl_reg_table;
|
||||
static const unsigned int zero = 0;
|
||||
static const unsigned int one = 1;
|
||||
static const unsigned int four = 4;
|
||||
static const unsigned int thirtytwo = 32;
|
||||
|
Reference in New Issue
Block a user