xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ARM: OMAP2: Delete an unnecessary check

Browse Source 
The of_node_put() function tests whether its argument is NULL and then
returns immediately if so.  Furthermore, the kerneldoc for
of_node_put() explicitly supports passing in a NULL pointer as its
argument.  Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
[paul@pwsan.com: dropped the omap_device.c and omap_hwmod.c changes for
 now, edited the commit message accordingly and to note the documented
 "contract"]
Reviewed-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
This commit is contained in:
Markus Elfring
2015-06-30 14:00:16 +02:00
committed by Paul Walmsley
parent 9e5d46b051
commit 9a0cb98589
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
arch/arm/mach-omap2/timer.c
View File

@@ -208,7 +208,6 @@ static void __init omap_dmtimer_init(void)
/* If we are a secure device, remove any secure timer nodes */ /* If we are a secure device, remove any secure timer nodes */
if ((omap_type() != OMAP2_DEVICE_TYPE_GP)) { if ((omap_type() != OMAP2_DEVICE_TYPE_GP)) {
np = omap_get_timer_dt(omap_timer_match, "ti,timer-secure"); np = omap_get_timer_dt(omap_timer_match, "ti,timer-secure");
if (np)
of_node_put(np); of_node_put(np);
} }
} }