Merge tag 'uninit-macro-v5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
Pull uninitialized_var() macro removal from Kees Cook: "This is long overdue, and has hidden too many bugs over the years. The series has several "by hand" fixes, and then a trivial treewide replacement. - Clean up non-trivial uses of uninitialized_var() - Update documentation and checkpatch for uninitialized_var() removal - Treewide removal of uninitialized_var()" * tag 'uninit-macro-v5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux: compiler: Remove uninitialized_var() macro treewide: Remove uninitialized_var() usage checkpatch: Remove awareness of uninitialized_var() macro mm/debug_vm_pgtable: Remove uninitialized_var() usage f2fs: Eliminate usage of uninitialized_var() macro media: sur40: Remove uninitialized_var() usage KVM: PPC: Book3S PR: Remove uninitialized_var() usage clk: spear: Remove uninitialized_var() usage clk: st: Remove uninitialized_var() usage spi: davinci: Remove uninitialized_var() usage ide: Remove uninitialized_var() usage rtlwifi: rtl8192cu: Remove uninitialized_var() usage b43: Remove uninitialized_var() usage drbd: Remove uninitialized_var() usage x86/mm/numa: Remove uninitialized_var() usage docs: deprecated.rst: Add uninitialized_var()
This commit is contained in:
@@ -56,7 +56,7 @@ int dccp_parse_options(struct sock *sk, struct dccp_request_sock *dreq,
|
||||
(dh->dccph_doff * 4);
|
||||
struct dccp_options_received *opt_recv = &dp->dccps_options_received;
|
||||
unsigned char opt, len;
|
||||
unsigned char *uninitialized_var(value);
|
||||
unsigned char *value;
|
||||
u32 elapsed_time;
|
||||
__be32 opt_val;
|
||||
int rc;
|
||||
|
@@ -84,11 +84,11 @@ nf_socket_get_sock_v4(struct net *net, struct sk_buff *skb, const int doff,
|
||||
struct sock *nf_sk_lookup_slow_v4(struct net *net, const struct sk_buff *skb,
|
||||
const struct net_device *indev)
|
||||
{
|
||||
__be32 uninitialized_var(daddr), uninitialized_var(saddr);
|
||||
__be16 uninitialized_var(dport), uninitialized_var(sport);
|
||||
__be32 daddr, saddr;
|
||||
__be16 dport, sport;
|
||||
const struct iphdr *iph = ip_hdr(skb);
|
||||
struct sk_buff *data_skb = NULL;
|
||||
u8 uninitialized_var(protocol);
|
||||
u8 protocol;
|
||||
#if IS_ENABLED(CONFIG_NF_CONNTRACK)
|
||||
enum ip_conntrack_info ctinfo;
|
||||
struct nf_conn const *ct;
|
||||
|
@@ -535,7 +535,7 @@ int ipv6_flowlabel_opt_get(struct sock *sk, struct in6_flowlabel_req *freq,
|
||||
|
||||
int ipv6_flowlabel_opt(struct sock *sk, char __user *optval, int optlen)
|
||||
{
|
||||
int uninitialized_var(err);
|
||||
int err;
|
||||
struct net *net = sock_net(sk);
|
||||
struct ipv6_pinfo *np = inet6_sk(sk);
|
||||
struct in6_flowlabel_req freq;
|
||||
|
@@ -97,7 +97,7 @@ nf_socket_get_sock_v6(struct net *net, struct sk_buff *skb, int doff,
|
||||
struct sock *nf_sk_lookup_slow_v6(struct net *net, const struct sk_buff *skb,
|
||||
const struct net_device *indev)
|
||||
{
|
||||
__be16 uninitialized_var(dport), uninitialized_var(sport);
|
||||
__be16 dport, sport;
|
||||
const struct in6_addr *daddr = NULL, *saddr = NULL;
|
||||
struct ipv6hdr *iph = ipv6_hdr(skb);
|
||||
struct sk_buff *data_skb = NULL;
|
||||
|
@@ -382,7 +382,7 @@ static int help(struct sk_buff *skb,
|
||||
int ret;
|
||||
u32 seq;
|
||||
int dir = CTINFO2DIR(ctinfo);
|
||||
unsigned int uninitialized_var(matchlen), uninitialized_var(matchoff);
|
||||
unsigned int matchlen, matchoff;
|
||||
struct nf_ct_ftp_master *ct_ftp_info = nfct_help_data(ct);
|
||||
struct nf_conntrack_expect *exp;
|
||||
union nf_inet_addr *daddr;
|
||||
|
@@ -689,7 +689,7 @@ nfulnl_log_packet(struct net *net,
|
||||
struct nfnl_log_net *log = nfnl_log_pernet(net);
|
||||
const struct nfnl_ct_hook *nfnl_ct = NULL;
|
||||
struct nf_conn *ct = NULL;
|
||||
enum ip_conntrack_info uninitialized_var(ctinfo);
|
||||
enum ip_conntrack_info ctinfo;
|
||||
|
||||
if (li_user && li_user->type == NF_LOG_TYPE_ULOG)
|
||||
li = li_user;
|
||||
|
@@ -388,7 +388,7 @@ nfqnl_build_packet_message(struct net *net, struct nfqnl_instance *queue,
|
||||
struct net_device *indev;
|
||||
struct net_device *outdev;
|
||||
struct nf_conn *ct = NULL;
|
||||
enum ip_conntrack_info uninitialized_var(ctinfo);
|
||||
enum ip_conntrack_info ctinfo;
|
||||
struct nfnl_ct_hook *nfnl_ct;
|
||||
bool csum_verify;
|
||||
char *secdata = NULL;
|
||||
@@ -1168,7 +1168,7 @@ static int nfqnl_recv_verdict(struct net *net, struct sock *ctnl,
|
||||
struct nfqnl_instance *queue;
|
||||
unsigned int verdict;
|
||||
struct nf_queue_entry *entry;
|
||||
enum ip_conntrack_info uninitialized_var(ctinfo);
|
||||
enum ip_conntrack_info ctinfo;
|
||||
struct nfnl_ct_hook *nfnl_ct;
|
||||
struct nf_conn *ct = NULL;
|
||||
struct nfnl_queue_net *q = nfnl_queue_pernet(net);
|
||||
|
@@ -225,7 +225,7 @@ static u32 flow_get_skgid(const struct sk_buff *skb)
|
||||
|
||||
static u32 flow_get_vlan_tag(const struct sk_buff *skb)
|
||||
{
|
||||
u16 uninitialized_var(tag);
|
||||
u16 tag;
|
||||
|
||||
if (vlan_get_tag(skb, &tag) < 0)
|
||||
return 0;
|
||||
|
@@ -1692,7 +1692,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch,
|
||||
{
|
||||
struct cake_sched_data *q = qdisc_priv(sch);
|
||||
int len = qdisc_pkt_len(skb);
|
||||
int uninitialized_var(ret);
|
||||
int ret;
|
||||
struct sk_buff *ack = NULL;
|
||||
ktime_t now = ktime_get();
|
||||
struct cake_tin_data *b;
|
||||
|
@@ -360,7 +360,7 @@ cbq_enqueue(struct sk_buff *skb, struct Qdisc *sch,
|
||||
struct sk_buff **to_free)
|
||||
{
|
||||
struct cbq_sched_data *q = qdisc_priv(sch);
|
||||
int uninitialized_var(ret);
|
||||
int ret;
|
||||
struct cbq_class *cl = cbq_classify(skb, sch, &ret);
|
||||
|
||||
#ifdef CONFIG_NET_CLS_ACT
|
||||
|
@@ -187,7 +187,7 @@ static int fq_codel_enqueue(struct sk_buff *skb, struct Qdisc *sch,
|
||||
struct fq_codel_sched_data *q = qdisc_priv(sch);
|
||||
unsigned int idx, prev_backlog, prev_qlen;
|
||||
struct fq_codel_flow *flow;
|
||||
int uninitialized_var(ret);
|
||||
int ret;
|
||||
unsigned int pkt_len;
|
||||
bool memory_limited;
|
||||
|
||||
|
@@ -130,7 +130,7 @@ static int fq_pie_qdisc_enqueue(struct sk_buff *skb, struct Qdisc *sch,
|
||||
{
|
||||
struct fq_pie_sched_data *q = qdisc_priv(sch);
|
||||
struct fq_pie_flow *sel_flow;
|
||||
int uninitialized_var(ret);
|
||||
int ret;
|
||||
u8 memory_limited = false;
|
||||
u8 enqueue = false;
|
||||
u32 pkt_len;
|
||||
|
@@ -1533,7 +1533,7 @@ hfsc_enqueue(struct sk_buff *skb, struct Qdisc *sch, struct sk_buff **to_free)
|
||||
{
|
||||
unsigned int len = qdisc_pkt_len(skb);
|
||||
struct hfsc_class *cl;
|
||||
int uninitialized_var(err);
|
||||
int err;
|
||||
bool first;
|
||||
|
||||
cl = hfsc_classify(skb, sch, &err);
|
||||
|
@@ -579,7 +579,7 @@ static inline void htb_deactivate(struct htb_sched *q, struct htb_class *cl)
|
||||
static int htb_enqueue(struct sk_buff *skb, struct Qdisc *sch,
|
||||
struct sk_buff **to_free)
|
||||
{
|
||||
int uninitialized_var(ret);
|
||||
int ret;
|
||||
unsigned int len = qdisc_pkt_len(skb);
|
||||
struct htb_sched *q = qdisc_priv(sch);
|
||||
struct htb_class *cl = htb_classify(skb, sch, &ret);
|
||||
|
@@ -349,7 +349,7 @@ sfq_enqueue(struct sk_buff *skb, struct Qdisc *sch, struct sk_buff **to_free)
|
||||
unsigned int hash, dropped;
|
||||
sfq_index x, qlen;
|
||||
struct sfq_slot *slot;
|
||||
int uninitialized_var(ret);
|
||||
int ret;
|
||||
struct sk_buff *head;
|
||||
int delta;
|
||||
|
||||
|
@@ -564,7 +564,7 @@ static int svc_udp_sendto(struct svc_rqst *rqstp)
|
||||
.msg_control = cmh,
|
||||
.msg_controllen = sizeof(buffer),
|
||||
};
|
||||
unsigned int uninitialized_var(sent);
|
||||
unsigned int sent;
|
||||
int err;
|
||||
|
||||
svc_udp_release_rqst(rqstp);
|
||||
@@ -1081,7 +1081,7 @@ static int svc_tcp_sendto(struct svc_rqst *rqstp)
|
||||
struct msghdr msg = {
|
||||
.msg_flags = 0,
|
||||
};
|
||||
unsigned int uninitialized_var(sent);
|
||||
unsigned int sent;
|
||||
int err;
|
||||
|
||||
svc_tcp_release_rqst(rqstp);
|
||||
|
@@ -496,8 +496,8 @@ xs_read_stream_request(struct sock_xprt *transport, struct msghdr *msg,
|
||||
int flags, struct rpc_rqst *req)
|
||||
{
|
||||
struct xdr_buf *buf = &req->rq_private_buf;
|
||||
size_t want, uninitialized_var(read);
|
||||
ssize_t uninitialized_var(ret);
|
||||
size_t want, read;
|
||||
ssize_t ret;
|
||||
|
||||
xs_read_header(transport, buf);
|
||||
|
||||
@@ -844,7 +844,7 @@ static int xs_local_send_request(struct rpc_rqst *req)
|
||||
struct msghdr msg = {
|
||||
.msg_flags = XS_SENDMSG_FLAGS,
|
||||
};
|
||||
unsigned int uninitialized_var(sent);
|
||||
unsigned int sent;
|
||||
int status;
|
||||
|
||||
/* Close the stream if the previous transmission was incomplete */
|
||||
@@ -915,7 +915,7 @@ static int xs_udp_send_request(struct rpc_rqst *req)
|
||||
.msg_namelen = xprt->addrlen,
|
||||
.msg_flags = XS_SENDMSG_FLAGS,
|
||||
};
|
||||
unsigned int uninitialized_var(sent);
|
||||
unsigned int sent;
|
||||
int status;
|
||||
|
||||
xs_pktdump("packet data:",
|
||||
@@ -999,7 +999,7 @@ static int xs_tcp_send_request(struct rpc_rqst *req)
|
||||
.msg_flags = XS_SENDMSG_FLAGS,
|
||||
};
|
||||
bool vm_wait = false;
|
||||
unsigned int uninitialized_var(sent);
|
||||
unsigned int sent;
|
||||
int status;
|
||||
|
||||
/* Close the stream if the previous transmission was incomplete */
|
||||
|
@@ -670,7 +670,7 @@ static int tls_push_record(struct sock *sk, int flags,
|
||||
struct tls_prot_info *prot = &tls_ctx->prot_info;
|
||||
struct tls_sw_context_tx *ctx = tls_sw_ctx_tx(tls_ctx);
|
||||
struct tls_rec *rec = ctx->open_rec, *tmp = NULL;
|
||||
u32 i, split_point, uninitialized_var(orig_end);
|
||||
u32 i, split_point, orig_end;
|
||||
struct sk_msg *msg_pl, *msg_en;
|
||||
struct aead_request *req;
|
||||
bool split;
|
||||
|
Reference in New Issue
Block a user