proc 2/2: remove struct proc_dir_entry::owner
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy as correctly noted at bug #12454. Someone can lookup entry with NULL ->owner, thus not pinning enything, and release it later resulting in module refcount underflow. We can keep ->owner and supply it at registration time like ->proc_fops and ->data. But this leaves ->owner as easy-manipulative field (just one C assignment) and somebody will forget to unpin previous/pin current module when switching ->owner. ->proc_fops is declared as "const" which should give some thoughts. ->read_proc/->write_proc were just fixed to not require ->owner for protection. rmmod'ed directories will be empty and return "." and ".." -- no harm. And directories with tricky enough readdir and lookup shouldn't be modular. We definitely don't want such modular code. Removing ->owner will also make PDE smaller. So, let's nuke it. Kudos to Jeff Layton for reminding about this, let's say, oversight. http://bugzilla.kernel.org/show_bug.cgi?id=12454 Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
这个提交包含在:
@@ -70,7 +70,6 @@ void __init irda_proc_register(void)
|
||||
proc_irda = proc_mkdir("irda", init_net.proc_net);
|
||||
if (proc_irda == NULL)
|
||||
return;
|
||||
proc_irda->owner = THIS_MODULE;
|
||||
|
||||
for (i = 0; i < ARRAY_SIZE(irda_dirs); i++)
|
||||
d = proc_create(irda_dirs[i].name, 0, proc_irda,
|
||||
|
在新工单中引用
屏蔽一个用户