perf tools: Support callchain sorting based on addresses
With programs with very large functions it can be useful to distinguish the callgraph nodes on more than just function names. So for example if you have multiple calls to the same function, it ends up being separate nodes in the chain. This patch adds a new key field to the callgraph options, that allows comparing nodes on functions (as today, default) and addresses. Longer term it would be nice to also handle src lines, but that would need more changes and address is a reasonable proxy for it today. I right now reference the global params, as there was no simple way to register a params pointer. Signed-off-by: Andi Kleen <ak@linux.intel.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Link: http://lkml.kernel.org/n/tip-0uskktybf0e7wrnoi5e9b9it@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:

committed by
Arnaldo Carvalho de Melo

parent
a198996c7a
commit
99571ab3d9
@@ -15,6 +15,7 @@
|
||||
#include <errno.h>
|
||||
#include <math.h>
|
||||
|
||||
#include "hist.h"
|
||||
#include "util.h"
|
||||
#include "callchain.h"
|
||||
|
||||
@@ -327,7 +328,8 @@ append_chain(struct callchain_node *root,
|
||||
/*
|
||||
* Lookup in the current node
|
||||
* If we have a symbol, then compare the start to match
|
||||
* anywhere inside a function.
|
||||
* anywhere inside a function, unless function
|
||||
* mode is disabled.
|
||||
*/
|
||||
list_for_each_entry(cnode, &root->val, list) {
|
||||
struct callchain_cursor_node *node;
|
||||
@@ -339,7 +341,8 @@ append_chain(struct callchain_node *root,
|
||||
|
||||
sym = node->sym;
|
||||
|
||||
if (cnode->ms.sym && sym) {
|
||||
if (cnode->ms.sym && sym &&
|
||||
callchain_param.key == CCKEY_FUNCTION) {
|
||||
if (cnode->ms.sym->start != sym->start)
|
||||
break;
|
||||
} else if (cnode->ip != node->ip)
|
||||
|
Reference in New Issue
Block a user