xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf map: Move maj/min/ino/ino_generation to separate struct

Browse Source 
And this patch highlights where these fields are being used: in the sort
order where it uses it to compare maps and classify samples taking into
account not just the DSO, but those DSO id fields.

I think these should be used to differentiate DSOs with the same name
but different 'struct dso_id' fields, i.e. these fields should move to
'struct dso' and then be used as part of the key when doing lookups for
DSOs, in addition to the DSO name.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-8v5isitqy0dup47nnwkpc80f@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo
2019-11-19 12:26:19 -03:00
parent 8f6ee51d77
commit 99459a84d5
4 changed files with 28 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tools/perf/util/map.h
View File

@@ -18,6 +18,16 @@ struct map_groups;
struct machine;
struct evsel;
/*
* Data about backing storage DSO, comes from PERF_RECORD_MMAP2 meta events
*/
struct dso_id {
u32 maj;
u32 min;
u64 ino;
u64 ino_generation;
};
struct map {
union {
struct rb_node rb_node;
@@ -30,9 +40,6 @@ struct map {
u32 prot;
u64 pgoff;
u64 reloc;
u32 maj, min; /* only valid for MMAP2 record */
u64 ino; /* only valid for MMAP2 record */
u64 ino_generation;/* only valid for MMAP2 record */
/* ip -> dso rip */
u64 (*map_ip)(struct map *, u64);
@@ -40,6 +47,7 @@ struct map {
u64 (*unmap_ip)(struct map *, u64);
struct dso *dso;
struct dso_id dso_id;
refcount_t refcnt;
u32 flags;
};