ARM: omap: move dma channel allocation into plat-omap code
This really needs to be there, because otherwise the plat-omap code can kfree() this data structure, and then re-use the pointer later. Acked-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
This commit is contained in:
@@ -2030,9 +2030,16 @@ static int omap_system_dma_probe(struct platform_device *pdev)
|
||||
|
||||
dma_lch_count = d->lch_count;
|
||||
dma_chan_count = dma_lch_count;
|
||||
dma_chan = d->chan;
|
||||
enable_1510_mode = d->dev_caps & ENABLE_1510_MODE;
|
||||
|
||||
dma_chan = devm_kcalloc(&pdev->dev, dma_lch_count,
|
||||
sizeof(struct omap_dma_lch), GFP_KERNEL);
|
||||
if (!dma_chan) {
|
||||
dev_err(&pdev->dev, "%s: kzalloc fail\n", __func__);
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
|
||||
if (dma_omap2plus()) {
|
||||
dma_linked_lch = kzalloc(sizeof(struct dma_link_info) *
|
||||
dma_lch_count, GFP_KERNEL);
|
||||
@@ -2117,7 +2124,6 @@ exit_dma_irq_fail:
|
||||
}
|
||||
|
||||
exit_dma_lch_fail:
|
||||
kfree(dma_chan);
|
||||
return ret;
|
||||
}
|
||||
|
||||
@@ -2137,7 +2143,6 @@ static int omap_system_dma_remove(struct platform_device *pdev)
|
||||
free_irq(dma_irq, (void *)(irq_rel + 1));
|
||||
}
|
||||
}
|
||||
kfree(dma_chan);
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user