xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PATCH] ata: fix platform_device_register_simple() error check

Browse Source 
The return value of platform_device_register_simple() should be checked
by IS_ERR().

Cc: Jeff Garzik <jgarzik@pobox.com>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Akinobu Mita
2006-12-15 13:08:51 -08:00
committed by Jeff Garzik
parent 551c012d7e
commit 9825d73ceb
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/ata/pata_legacy.c
View File

@@ -698,8 +698,10 @@ static __init int legacy_init_one(int port, unsigned long io, unsigned long ctrl
goto fail_io; goto fail_io;
pdev = platform_device_register_simple(DRV_NAME, nr_legacy_host, NULL, 0); pdev = platform_device_register_simple(DRV_NAME, nr_legacy_host, NULL, 0);
if (pdev == NULL) if (IS_ERR(pdev)) {
ret = PTR_ERR(pdev);
goto fail_dev; goto fail_dev;
}
if (ht6560a & mask) { if (ht6560a & mask) {
ops = &ht6560a_port_ops; ops = &ht6560a_port_ops;

4
drivers/ata/pata_qdi.c
View File

@@ -247,8 +247,8 @@ static __init int qdi_init_one(unsigned long port, int type, unsigned long io, i
*/ */
pdev = platform_device_register_simple(DRV_NAME, nr_qdi_host, NULL, 0); pdev = platform_device_register_simple(DRV_NAME, nr_qdi_host, NULL, 0);
if (pdev == NULL) if (IS_ERR(pdev))
return -ENOMEM; return PTR_ERR(pdev);
memset(&ae, 0, sizeof(struct ata_probe_ent)); memset(&ae, 0, sizeof(struct ata_probe_ent));
INIT_LIST_HEAD(&ae.node); INIT_LIST_HEAD(&ae.node);

4
drivers/ata/pata_winbond.c
View File

@@ -206,8 +206,8 @@ static __init int winbond_init_one(unsigned long port)
*/ */
pdev = platform_device_register_simple(DRV_NAME, nr_winbond_host, NULL, 0); pdev = platform_device_register_simple(DRV_NAME, nr_winbond_host, NULL, 0);
if (pdev == NULL) if (IS_ERR(pdev))
return -ENOMEM; return PTR_ERR(pdev);
memset(&ae, 0, sizeof(struct ata_probe_ent)); memset(&ae, 0, sizeof(struct ata_probe_ent));
INIT_LIST_HEAD(&ae.node); INIT_LIST_HEAD(&ae.node);