xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ext4: Send notifications on error

Browse Source 
commit 9a089b21f79b47eed240d4da7ea0d049de7c9b4d upstream.

Send a FS_ERROR message via fsnotify to a userspace monitoring tool
whenever a ext4 error condition is triggered.  This follows the existing
error conditions in ext4, so it is hooked to the ext4_error* functions.

Link: https://lore.kernel.org/r/20211025192746.66445-30-krisman@collabora.com
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Acked-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jan Kara <jack@suse.cz>
[Ajay: - Modified to apply on v5.10.y
       - Added fsnotify for __ext4_abort()]
Signed-off-by: Ajay Kaher <ajay.kaher@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Gabriel Krisman Bertazi
2021-10-25 16:27:44 -03:00
committed by Greg Kroah-Hartman
parent 88e44424a6
commit 9760c6ceb2
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
fs/ext4/super.c
View File

@@ -46,6 +46,7 @@
#include <linux/part_stat.h> #include <linux/part_stat.h>
#include <linux/kthread.h> #include <linux/kthread.h>
#include <linux/freezer.h> #include <linux/freezer.h>
#include <linux/fsnotify.h>
#include "ext4.h" #include "ext4.h"
#include "ext4_extents.h" /* Needed for trace points definition */ #include "ext4_extents.h" /* Needed for trace points definition */
@@ -699,6 +700,7 @@ void __ext4_error(struct super_block *sb, const char *function,
sb->s_id, function, line, current->comm, &vaf); sb->s_id, function, line, current->comm, &vaf);
va_end(args); va_end(args);
} }
fsnotify_sb_error(sb, NULL, error ? error : EFSCORRUPTED);
save_error_info(sb, error, 0, block, function, line); save_error_info(sb, error, 0, block, function, line);
ext4_handle_error(sb); ext4_handle_error(sb);
} }
@@ -730,6 +732,7 @@ void __ext4_error_inode(struct inode *inode, const char *function,
current->comm, &vaf); current->comm, &vaf);
va_end(args); va_end(args);
} }
fsnotify_sb_error(inode->i_sb, inode, error ? error : EFSCORRUPTED);
save_error_info(inode->i_sb, error, inode->i_ino, block, save_error_info(inode->i_sb, error, inode->i_ino, block,
function, line); function, line);
ext4_handle_error(inode->i_sb); ext4_handle_error(inode->i_sb);
@@ -769,6 +772,7 @@ void __ext4_error_file(struct file *file, const char *function,
current->comm, path, &vaf); current->comm, path, &vaf);
va_end(args); va_end(args);
} }
fsnotify_sb_error(inode->i_sb, inode, EFSCORRUPTED);
save_error_info(inode->i_sb, EFSCORRUPTED, inode->i_ino, block, save_error_info(inode->i_sb, EFSCORRUPTED, inode->i_ino, block,
function, line); function, line);
ext4_handle_error(inode->i_sb); ext4_handle_error(inode->i_sb);
@@ -837,7 +841,7 @@ void __ext4_std_error(struct super_block *sb, const char *function,
printk(KERN_CRIT "EXT4-fs error (device %s) in %s:%d: %s\n", printk(KERN_CRIT "EXT4-fs error (device %s) in %s:%d: %s\n",
sb->s_id, function, line, errstr); sb->s_id, function, line, errstr);
} }
fsnotify_sb_error(sb, NULL, errno ? errno : EFSCORRUPTED);
save_error_info(sb, -errno, 0, 0, function, line); save_error_info(sb, -errno, 0, 0, function, line);
ext4_handle_error(sb); ext4_handle_error(sb);
} }
@@ -861,6 +865,7 @@ void __ext4_abort(struct super_block *sb, const char *function,
if (unlikely(ext4_forced_shutdown(EXT4_SB(sb)))) if (unlikely(ext4_forced_shutdown(EXT4_SB(sb))))
return; return;
fsnotify_sb_error(sb, NULL, error ? error : EFSCORRUPTED);
save_error_info(sb, error, 0, 0, function, line); save_error_info(sb, error, 0, 0, function, line);
va_start(args, fmt); va_start(args, fmt);
vaf.fmt = fmt; vaf.fmt = fmt;