gfs2: Don't pack struct lm_lockname
As per a suggestion by Linus, don't pack struct lm_lockname: we did that because the struct is used as a rhashtable key, but packing tells the compiler that the 64-bit fields in the struct may be unaligned, causing it to generate worse code on some architectures. Instead, rearrange the fields in the struct so that there is no padding between fields, and exclude any tail padding from the hash key size. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
This commit is contained in:

committed by
Bob Peterson

parent
92ecd73a88
commit
972b044eec
@@ -73,7 +73,7 @@ static DEFINE_SPINLOCK(lru_lock);
|
||||
|
||||
static struct rhashtable_params ht_parms = {
|
||||
.nelem_hint = GFS2_GL_HASH_SIZE * 3 / 4,
|
||||
.key_len = sizeof(struct lm_lockname),
|
||||
.key_len = offsetofend(struct lm_lockname, ln_type),
|
||||
.key_offset = offsetof(struct gfs2_glock, gl_name),
|
||||
.head_offset = offsetof(struct gfs2_glock, gl_node),
|
||||
};
|
||||
|
Reference in New Issue
Block a user