xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

isp1362-hcd: don't reimplement proc_create_data()

Browse Source 
... especially in a racy way

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro
2013-03-30 13:15:27 -04:00
parent 5a787a6820
commit 96e7d9158f
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/host/isp1362-hcd.c
View File

@@ -2192,14 +2192,11 @@ static void create_debug_file(struct isp1362_hcd *isp1362_hcd)
{ {
struct proc_dir_entry *pde; struct proc_dir_entry *pde;
pde = create_proc_entry(proc_filename, 0, NULL); pde = proc_create_data(proc_filename, 0, NULL, &proc_ops, isp1362_hcd);
if (pde == NULL) { if (pde == NULL) {
pr_warning("%s: Failed to create debug file '%s'\n", __func__, proc_filename); pr_warning("%s: Failed to create debug file '%s'\n", __func__, proc_filename);
return; return;
} }
pde->proc_fops = &proc_ops;
pde->data = isp1362_hcd;
isp1362_hcd->pde = pde; isp1362_hcd->pde = pde;
} }