xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform/mellanox: mlxbf-tmfifo: Fix a warning message

Browse Source 
[ Upstream commit 99c09c985e5973c8f0ad976ebae069548dd86f12 ]

This commit fixes the smatch static checker warning in function
mlxbf_tmfifo_rxtx_word() which complains data not initialized at
line 634 when IS_VRING_DROP() is TRUE.

Signed-off-by: Liming Sun <limings@nvidia.com>
Link: https://lore.kernel.org/r/20231012230235.219861-1-limings@nvidia.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Liming Sun
2023-10-12 19:02:35 -04:00
committed by Greg Kroah-Hartman
parent 268ec38b79
commit 955a1105ee
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/platform/mellanox/mlxbf-tmfifo.c
View File

@@ -588,24 +588,25 @@ static void mlxbf_tmfifo_rxtx_word(struct mlxbf_tmfifo_vring *vring,
if (vring->cur_len + sizeof(u64) <= len) { if (vring->cur_len + sizeof(u64) <= len) {
/* The whole word. */ /* The whole word. */
if (!IS_VRING_DROP(vring)) { if (is_rx) {
if (is_rx) if (!IS_VRING_DROP(vring))
memcpy(addr + vring->cur_len, &data, memcpy(addr + vring->cur_len, &data,
sizeof(u64)); sizeof(u64));
else } else {
memcpy(&data, addr + vring->cur_len, memcpy(&data, addr + vring->cur_len,
sizeof(u64)); sizeof(u64));
} }
vring->cur_len += sizeof(u64); vring->cur_len += sizeof(u64);
} else { } else {
/* Leftover bytes. */ /* Leftover bytes. */
if (!IS_VRING_DROP(vring)) { if (is_rx) {
if (is_rx) if (!IS_VRING_DROP(vring))
memcpy(addr + vring->cur_len, &data, memcpy(addr + vring->cur_len, &data,
len - vring->cur_len); len - vring->cur_len);
else } else {
memcpy(&data, addr + vring->cur_len, data = 0;
len - vring->cur_len); memcpy(&data, addr + vring->cur_len,
len - vring->cur_len);
} }
vring->cur_len = len; vring->cur_len = len;
} }