powerpc: Use a datatype for instructions
Currently unsigned ints are used to represent instructions on powerpc. This has worked well as instructions have always been 4 byte words. However, ISA v3.1 introduces some changes to instructions that mean this scheme will no longer work as well. This change is Prefixed Instructions. A prefixed instruction is made up of a word prefix followed by a word suffix to make an 8 byte double word instruction. No matter the endianness of the system the prefix always comes first. Prefixed instructions are only planned for powerpc64. Introduce a ppc_inst type to represent both prefixed and word instructions on powerpc64 while keeping it possible to exclusively have word instructions on powerpc32. Signed-off-by: Jordan Niethe <jniethe5@gmail.com> [mpe: Fix compile error in emulate_spe()] Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20200506034050.24806-12-jniethe5@gmail.com
This commit is contained in:

committed by
Michael Ellerman

parent
217862d9b9
commit
94afd069d9
@@ -1163,7 +1163,7 @@ static nokprobe_inline int trap_compare(long v1, long v2)
|
||||
* otherwise.
|
||||
*/
|
||||
int analyse_instr(struct instruction_op *op, const struct pt_regs *regs,
|
||||
unsigned int instr)
|
||||
struct ppc_inst instr)
|
||||
{
|
||||
unsigned int opcode, ra, rb, rc, rd, spr, u;
|
||||
unsigned long int imm;
|
||||
@@ -3103,7 +3103,7 @@ NOKPROBE_SYMBOL(emulate_loadstore);
|
||||
* or -1 if the instruction is one that should not be stepped,
|
||||
* such as an rfid, or a mtmsrd that would clear MSR_RI.
|
||||
*/
|
||||
int emulate_step(struct pt_regs *regs, unsigned int instr)
|
||||
int emulate_step(struct pt_regs *regs, struct ppc_inst instr)
|
||||
{
|
||||
struct instruction_op op;
|
||||
int r, err, type;
|
||||
|
Reference in New Issue
Block a user