audit: call audit_bprm() only once to add AUDIT_EXECVE information

Move the audit_bprm() call from search_binary_handler() to exec_binprm().  This
allows us to get rid of the mm member of struct audit_aux_data_execve since
bprm->mm will equal current->mm.

This also mitigates the issue that ->argc could be modified by the
load_binary() call in search_binary_handler().

audit_bprm() was being called to add an AUDIT_EXECVE record to the audit
context every time search_binary_handler() was recursively called.  Only one
reference is necessary.

Reported-by: Oleg Nesterov <onestero@redhat.com>
Cc: Eric Paris <eparis@redhat.com>
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
---
This patch is against 3.11, but was developed on Oleg's post-3.11 patches that
introduce exec_binprm().
This commit is contained in:
Richard Guy Briggs
2013-10-30 18:05:24 -04:00
committed by Eric Paris
parent d9cfea91e9
commit 9410d228a4
4 changed files with 4 additions and 15 deletions

View File

@@ -199,7 +199,6 @@ struct audit_context {
} mmap;
struct {
int argc;
struct mm_struct *mm;
} execve;
};
int fds[2];