Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull compat and uaccess updates from Al Viro: - {get,put}_compat_sigset() series - assorted compat ioctl stuff - more set_fs() elimination - a few more timespec64 conversions - several removals of pointless access_ok() in places where it was followed only by non-__ variants of primitives * 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (24 commits) coredump: call do_unlinkat directly instead of sys_unlink fs: expose do_unlinkat for built-in callers ext4: take handling of EXT4_IOC_GROUP_ADD into a helper, get rid of set_fs() ipmi: get rid of pointless access_ok() pi433: sanitize ioctl cxlflash: get rid of pointless access_ok() mtdchar: get rid of pointless access_ok() r128: switch compat ioctls to drm_ioctl_kernel() selection: get rid of field-by-field copyin VT_RESIZEX: get rid of field-by-field copyin i2c compat ioctls: move to ->compat_ioctl() sched_rr_get_interval(): move compat to native, get rid of set_fs() mips: switch to {get,put}_compat_sigset() sparc: switch to {get,put}_compat_sigset() s390: switch to {get,put}_compat_sigset() ppc: switch to {get,put}_compat_sigset() parisc: switch to {get,put}_compat_sigset() get_compat_sigset() get rid of {get,put}_compat_itimerspec() io_getevents: Use timespec64 to represent timeouts ...
This commit is contained in:
@@ -50,19 +50,6 @@ typedef struct
|
||||
struct ucontext32 uc;
|
||||
} rt_sigframe32;
|
||||
|
||||
static inline void sigset_to_sigset32(unsigned long *set64,
|
||||
compat_sigset_word *set32)
|
||||
{
|
||||
set32[0] = (compat_sigset_word) set64[0];
|
||||
set32[1] = (compat_sigset_word)(set64[0] >> 32);
|
||||
}
|
||||
|
||||
static inline void sigset32_to_sigset(compat_sigset_word *set32,
|
||||
unsigned long *set64)
|
||||
{
|
||||
set64[0] = (unsigned long) set32[0] | ((unsigned long) set32[1] << 32);
|
||||
}
|
||||
|
||||
int copy_siginfo_to_user32(compat_siginfo_t __user *to, const siginfo_t *from)
|
||||
{
|
||||
int err;
|
||||
@@ -294,12 +281,10 @@ COMPAT_SYSCALL_DEFINE0(sigreturn)
|
||||
{
|
||||
struct pt_regs *regs = task_pt_regs(current);
|
||||
sigframe32 __user *frame = (sigframe32 __user *)regs->gprs[15];
|
||||
compat_sigset_t cset;
|
||||
sigset_t set;
|
||||
|
||||
if (__copy_from_user(&cset.sig, &frame->sc.oldmask, _SIGMASK_COPY_SIZE32))
|
||||
if (get_compat_sigset(&set, (compat_sigset_t __user *)frame->sc.oldmask))
|
||||
goto badframe;
|
||||
sigset32_to_sigset(cset.sig, set.sig);
|
||||
set_current_blocked(&set);
|
||||
save_fpu_regs();
|
||||
if (restore_sigregs32(regs, &frame->sregs))
|
||||
@@ -317,12 +302,10 @@ COMPAT_SYSCALL_DEFINE0(rt_sigreturn)
|
||||
{
|
||||
struct pt_regs *regs = task_pt_regs(current);
|
||||
rt_sigframe32 __user *frame = (rt_sigframe32 __user *)regs->gprs[15];
|
||||
compat_sigset_t cset;
|
||||
sigset_t set;
|
||||
|
||||
if (__copy_from_user(&cset, &frame->uc.uc_sigmask, sizeof(cset)))
|
||||
if (get_compat_sigset(&set, &frame->uc.uc_sigmask))
|
||||
goto badframe;
|
||||
sigset32_to_sigset(cset.sig, set.sig);
|
||||
set_current_blocked(&set);
|
||||
if (compat_restore_altstack(&frame->uc.uc_stack))
|
||||
goto badframe;
|
||||
@@ -372,7 +355,6 @@ static int setup_frame32(struct ksignal *ksig, sigset_t *set,
|
||||
{
|
||||
int sig = ksig->sig;
|
||||
sigframe32 __user *frame;
|
||||
struct sigcontext32 sc;
|
||||
unsigned long restorer;
|
||||
size_t frame_size;
|
||||
|
||||
@@ -394,9 +376,10 @@ static int setup_frame32(struct ksignal *ksig, sigset_t *set,
|
||||
return -EFAULT;
|
||||
|
||||
/* Create struct sigcontext32 on the signal stack */
|
||||
sigset_to_sigset32(set->sig, sc.oldmask);
|
||||
sc.sregs = (__u32)(unsigned long __force) &frame->sregs;
|
||||
if (__copy_to_user(&frame->sc, &sc, sizeof(frame->sc)))
|
||||
if (put_compat_sigset((compat_sigset_t __user *)frame->sc.oldmask,
|
||||
set, sizeof(compat_sigset_t)))
|
||||
return -EFAULT;
|
||||
if (__put_user(ptr_to_compat(&frame->sc), &frame->sc.sregs))
|
||||
return -EFAULT;
|
||||
|
||||
/* Store registers needed to create the signal frame */
|
||||
@@ -455,7 +438,6 @@ static int setup_frame32(struct ksignal *ksig, sigset_t *set,
|
||||
static int setup_rt_frame32(struct ksignal *ksig, sigset_t *set,
|
||||
struct pt_regs *regs)
|
||||
{
|
||||
compat_sigset_t cset;
|
||||
rt_sigframe32 __user *frame;
|
||||
unsigned long restorer;
|
||||
size_t frame_size;
|
||||
@@ -502,12 +484,11 @@ static int setup_rt_frame32(struct ksignal *ksig, sigset_t *set,
|
||||
store_sigregs();
|
||||
|
||||
/* Create ucontext on the signal stack. */
|
||||
sigset_to_sigset32(set->sig, cset.sig);
|
||||
if (__put_user(uc_flags, &frame->uc.uc_flags) ||
|
||||
__put_user(0, &frame->uc.uc_link) ||
|
||||
__compat_save_altstack(&frame->uc.uc_stack, regs->gprs[15]) ||
|
||||
save_sigregs32(regs, &frame->uc.uc_mcontext) ||
|
||||
__copy_to_user(&frame->uc.uc_sigmask, &cset, sizeof(cset)) ||
|
||||
put_compat_sigset(&frame->uc.uc_sigmask, set, sizeof(compat_sigset_t)) ||
|
||||
save_sigregs_ext32(regs, &frame->uc.uc_mcontext_ext))
|
||||
return -EFAULT;
|
||||
|
||||
|
Reference in New Issue
Block a user