xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

phy: samsung: exynos5250-sata: fix missing device put in probe error paths

Browse Source 
[ Upstream commit 5c8402c4db45dd55c2c93c8d730f5dfa7c78a702 ]

The actions of of_find_i2c_device_by_node() in probe function should be
reversed in error paths by putting the reference to obtained device.

Fixes: bcff4cba41 ("PHY: Exynos: Add Exynos5250 SATA PHY driver")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Link: https://lore.kernel.org/r/20220407091857.230386-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Krzysztof Kozlowski
2022-04-07 11:18:57 +02:00
committed by Greg Kroah-Hartman
parent 3ca7491570
commit 93cc8f184e
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/phy/samsung/phy-exynos5250-sata.c
View File

@@ -199,20 +199,21 @@ static int exynos_sata_phy_probe(struct platform_device *pdev)
sata_phy->phyclk = devm_clk_get(dev, "sata_phyctrl"); sata_phy->phyclk = devm_clk_get(dev, "sata_phyctrl");
if (IS_ERR(sata_phy->phyclk)) { if (IS_ERR(sata_phy->phyclk)) {
dev_err(dev, "failed to get clk for PHY\n"); dev_err(dev, "failed to get clk for PHY\n");
return PTR_ERR(sata_phy->phyclk); ret = PTR_ERR(sata_phy->phyclk);
goto put_dev;
} }
ret = clk_prepare_enable(sata_phy->phyclk); ret = clk_prepare_enable(sata_phy->phyclk);
if (ret < 0) { if (ret < 0) {
dev_err(dev, "failed to enable source clk\n"); dev_err(dev, "failed to enable source clk\n");
return ret; goto put_dev;
} }
sata_phy->phy = devm_phy_create(dev, NULL, &exynos_sata_phy_ops); sata_phy->phy = devm_phy_create(dev, NULL, &exynos_sata_phy_ops);
if (IS_ERR(sata_phy->phy)) { if (IS_ERR(sata_phy->phy)) {
clk_disable_unprepare(sata_phy->phyclk);
dev_err(dev, "failed to create PHY\n"); dev_err(dev, "failed to create PHY\n");
return PTR_ERR(sata_phy->phy); ret = PTR_ERR(sata_phy->phy);
goto clk_disable;
} }
phy_set_drvdata(sata_phy->phy, sata_phy); phy_set_drvdata(sata_phy->phy, sata_phy);
@@ -220,11 +221,18 @@ static int exynos_sata_phy_probe(struct platform_device *pdev)
phy_provider = devm_of_phy_provider_register(dev, phy_provider = devm_of_phy_provider_register(dev,
of_phy_simple_xlate); of_phy_simple_xlate);
if (IS_ERR(phy_provider)) { if (IS_ERR(phy_provider)) {
clk_disable_unprepare(sata_phy->phyclk); ret = PTR_ERR(phy_provider);
return PTR_ERR(phy_provider); goto clk_disable;
} }
return 0; return 0;
clk_disable:
clk_disable_unprepare(sata_phy->phyclk);
put_dev:
put_device(&sata_phy->client->dev);
return ret;
} }
static const struct of_device_id exynos_sata_phy_of_match[] = { static const struct of_device_id exynos_sata_phy_of_match[] = {