xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xfs: change some error-less functions to void types

Browse Source 
There are several functions which have no opportunity to return
an error, and don't contain any ASSERTs which could be argued
to be better constructed as error cases.  So, make them voids
to simplify the callers.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
This commit is contained in:
Eric Sandeen
2019-05-01 20:26:30 -07:00
committed by Darrick J. Wong
parent 75efa57d0b
commit 910832697c
11 changed files with 26 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
fs/xfs/xfs_ioctl.c
View File

@@ -788,11 +788,8 @@ xfs_ioc_fsgeometry(
{
struct xfs_fsop_geom fsgeo;
size_t len;
int error;
error = xfs_fs_geometry(&mp->m_sb, &fsgeo, struct_version);
if (error)
return error;
xfs_fs_geometry(&mp->m_sb, &fsgeo, struct_version);
if (struct_version <= 3)
len = sizeof(struct xfs_fsop_geom_v1);
@@ -2046,9 +2043,7 @@ xfs_file_ioctl(
case XFS_IOC_FSCOUNTS: {
xfs_fsop_counts_t out;
error = xfs_fs_counts(mp, &out);
if (error)
return error;
xfs_fs_counts(mp, &out);
if (copy_to_user(arg, &out, sizeof(out)))
return -EFAULT;