[BLOCK] add @uptodate to end_that_request_last() and @error to rq_end_io_fn()
add @uptodate argument to end_that_request_last() and @error to rq_end_io_fn(). there's no generic way to pass error code to request completion function, making generic error handling of non-fs request difficult (rq->errors is driver-specific and each driver uses it differently). this patch adds @uptodate to end_that_request_last() and @error to rq_end_io_fn(). for fs requests, this doesn't really matter, so just using the same uptodate argument used in the last call to end_that_request_first() should suffice. imho, this can also help the generic command-carrying request jens is working on. Signed-off-by: tejun heo <htejun@gmail.com> Signed-Off-By: Jens Axboe <axboe@suse.de>
This commit is contained in:
@@ -1036,7 +1036,7 @@ static inline void complete_command(cmdlist_t *cmd, int timeout)
|
||||
complete_buffers(cmd->rq->bio, ok);
|
||||
|
||||
DBGPX(printk("Done with %p\n", cmd->rq););
|
||||
end_that_request_last(cmd->rq);
|
||||
end_that_request_last(cmd->rq, ok ? 1 : -EIO);
|
||||
}
|
||||
|
||||
/*
|
||||
|
Reference in New Issue
Block a user