IB/qib: Fix over-scheduling of QSFP work
Don't over-schedule QSFP work on driver initialization. It could end up being run simultaneously on two different CPUs resulting in bad EEPROM reads. In combination with setting the physical IB link state prior to the IBC being brought out of reset, this can cause the link state machine to start training early with wrong settings. Signed-off-by: Mitko Haralanov <mitko@qlogic.com> Signed-off-by: Mike Marciniszyn <mike.marciniszyn@qlogic.com> Signed-off-by: Roland Dreier <roland@purestorage.com>
Bu işleme şunda yer alıyor:

işlemeyi yapan:
Roland Dreier

ebeveyn
042f36e156
işleme
8ee887d74b
@@ -480,18 +480,6 @@ void qib_qsfp_init(struct qib_qsfp_data *qd,
|
||||
udelay(20); /* Generous RST dwell */
|
||||
|
||||
dd->f_gpio_mod(dd, mask, mask, mask);
|
||||
/* Spec says module can take up to two seconds! */
|
||||
mask = QSFP_GPIO_MOD_PRS_N;
|
||||
if (qd->ppd->hw_pidx)
|
||||
mask <<= QSFP_GPIO_PORT2_SHIFT;
|
||||
|
||||
/* Do not try to wait here. Better to let event handle it */
|
||||
if (!qib_qsfp_mod_present(qd->ppd))
|
||||
goto bail;
|
||||
/* We see a module, but it may be unwise to look yet. Just schedule */
|
||||
qd->t_insert = get_jiffies_64();
|
||||
queue_work(ib_wq, &qd->work);
|
||||
bail:
|
||||
return;
|
||||
}
|
||||
|
||||
|
Yeni konuda referans
Bir kullanıcı engelle