xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

serial: 8250: lock port for stop_rx() in omap8250_irq()

Browse Source 
[ Upstream commit ca73a892c5bec4b08a2fa22b3015e98ed905abb7 ]

The uarts_ops stop_rx() callback expects that the port->lock is
taken and interrupts are disabled.

Fixes: 1fe0e1fa3209 ("serial: 8250_omap: Handle optional overrun-throttle-ms property")
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20230525093159.223817-4-john.ogness@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
John Ogness
2023-05-25 11:37:54 +02:06
committed by Greg Kroah-Hartman
parent d66ddb61fa
commit 8d65d0a2bf
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/tty/serial/8250/8250_omap.c
View File

@@ -655,7 +655,9 @@ static irqreturn_t omap8250_irq(int irq, void *dev_id)
up->ier = port->serial_in(port, UART_IER); up->ier = port->serial_in(port, UART_IER);
if (up->ier & (UART_IER_RLSI | UART_IER_RDI)) { if (up->ier & (UART_IER_RLSI | UART_IER_RDI)) {
spin_lock(&port->lock);
port->ops->stop_rx(port); port->ops->stop_rx(port);
spin_unlock(&port->lock);
} else { } else {
/* Keep restarting the timer until /* Keep restarting the timer until
* the input overrun subsides. * the input overrun subsides.