sysctl: remove "struct file *" argument of ->proc_handler
It's unused. It isn't needed -- read or write flag is already passed and sysctl shouldn't care about the rest. It _was_ used in two places at arch/frv for some reason. Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Cc: David Howells <dhowells@redhat.com> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: "David S. Miller" <davem@davemloft.net> Cc: James Morris <jmorris@namei.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

zatwierdzone przez
Linus Torvalds

rodzic
c0d0787b6d
commit
8d65af789f
@@ -965,12 +965,12 @@ static struct nf_hook_ops br_nf_ops[] __read_mostly = {
|
||||
|
||||
#ifdef CONFIG_SYSCTL
|
||||
static
|
||||
int brnf_sysctl_call_tables(ctl_table * ctl, int write, struct file *filp,
|
||||
int brnf_sysctl_call_tables(ctl_table * ctl, int write,
|
||||
void __user * buffer, size_t * lenp, loff_t * ppos)
|
||||
{
|
||||
int ret;
|
||||
|
||||
ret = proc_dointvec(ctl, write, filp, buffer, lenp, ppos);
|
||||
ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
|
||||
|
||||
if (write && *(int *)(ctl->data))
|
||||
*(int *)(ctl->data) = 1;
|
||||
|
@@ -164,7 +164,7 @@ static int max_t3[] = { 8191 }; /* Must fit in 16 bits when multiplied by BCT3MU
|
||||
static int min_priority[1];
|
||||
static int max_priority[] = { 127 }; /* From DECnet spec */
|
||||
|
||||
static int dn_forwarding_proc(ctl_table *, int, struct file *,
|
||||
static int dn_forwarding_proc(ctl_table *, int,
|
||||
void __user *, size_t *, loff_t *);
|
||||
static int dn_forwarding_sysctl(ctl_table *table,
|
||||
void __user *oldval, size_t __user *oldlenp,
|
||||
@@ -274,7 +274,6 @@ static void dn_dev_sysctl_unregister(struct dn_dev_parms *parms)
|
||||
}
|
||||
|
||||
static int dn_forwarding_proc(ctl_table *table, int write,
|
||||
struct file *filep,
|
||||
void __user *buffer,
|
||||
size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
@@ -290,7 +289,7 @@ static int dn_forwarding_proc(ctl_table *table, int write,
|
||||
dn_db = dev->dn_ptr;
|
||||
old = dn_db->parms.forwarding;
|
||||
|
||||
err = proc_dointvec(table, write, filep, buffer, lenp, ppos);
|
||||
err = proc_dointvec(table, write, buffer, lenp, ppos);
|
||||
|
||||
if ((err >= 0) && write) {
|
||||
if (dn_db->parms.forwarding < 0)
|
||||
|
@@ -165,7 +165,6 @@ static int dn_node_address_strategy(ctl_table *table,
|
||||
}
|
||||
|
||||
static int dn_node_address_handler(ctl_table *table, int write,
|
||||
struct file *filp,
|
||||
void __user *buffer,
|
||||
size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
@@ -276,7 +275,6 @@ static int dn_def_dev_strategy(ctl_table *table,
|
||||
|
||||
|
||||
static int dn_def_dev_handler(ctl_table *table, int write,
|
||||
struct file * filp,
|
||||
void __user *buffer,
|
||||
size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
|
@@ -1270,10 +1270,10 @@ static void inet_forward_change(struct net *net)
|
||||
}
|
||||
|
||||
static int devinet_conf_proc(ctl_table *ctl, int write,
|
||||
struct file *filp, void __user *buffer,
|
||||
void __user *buffer,
|
||||
size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
int ret = proc_dointvec(ctl, write, filp, buffer, lenp, ppos);
|
||||
int ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
|
||||
|
||||
if (write) {
|
||||
struct ipv4_devconf *cnf = ctl->extra1;
|
||||
@@ -1342,12 +1342,12 @@ static int devinet_conf_sysctl(ctl_table *table,
|
||||
}
|
||||
|
||||
static int devinet_sysctl_forward(ctl_table *ctl, int write,
|
||||
struct file *filp, void __user *buffer,
|
||||
void __user *buffer,
|
||||
size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
int *valp = ctl->data;
|
||||
int val = *valp;
|
||||
int ret = proc_dointvec(ctl, write, filp, buffer, lenp, ppos);
|
||||
int ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
|
||||
|
||||
if (write && *valp != val) {
|
||||
struct net *net = ctl->extra2;
|
||||
@@ -1372,12 +1372,12 @@ static int devinet_sysctl_forward(ctl_table *ctl, int write,
|
||||
}
|
||||
|
||||
int ipv4_doint_and_flush(ctl_table *ctl, int write,
|
||||
struct file *filp, void __user *buffer,
|
||||
void __user *buffer,
|
||||
size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
int *valp = ctl->data;
|
||||
int val = *valp;
|
||||
int ret = proc_dointvec(ctl, write, filp, buffer, lenp, ppos);
|
||||
int ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
|
||||
struct net *net = ctl->extra2;
|
||||
|
||||
if (write && *valp != val)
|
||||
|
@@ -3036,7 +3036,7 @@ void ip_rt_multicast_event(struct in_device *in_dev)
|
||||
|
||||
#ifdef CONFIG_SYSCTL
|
||||
static int ipv4_sysctl_rtcache_flush(ctl_table *__ctl, int write,
|
||||
struct file *filp, void __user *buffer,
|
||||
void __user *buffer,
|
||||
size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
if (write) {
|
||||
@@ -3046,7 +3046,7 @@ static int ipv4_sysctl_rtcache_flush(ctl_table *__ctl, int write,
|
||||
|
||||
memcpy(&ctl, __ctl, sizeof(ctl));
|
||||
ctl.data = &flush_delay;
|
||||
proc_dointvec(&ctl, write, filp, buffer, lenp, ppos);
|
||||
proc_dointvec(&ctl, write, buffer, lenp, ppos);
|
||||
|
||||
net = (struct net *)__ctl->extra1;
|
||||
rt_cache_flush(net, flush_delay);
|
||||
@@ -3106,12 +3106,11 @@ static void rt_secret_reschedule(int old)
|
||||
}
|
||||
|
||||
static int ipv4_sysctl_rt_secret_interval(ctl_table *ctl, int write,
|
||||
struct file *filp,
|
||||
void __user *buffer, size_t *lenp,
|
||||
loff_t *ppos)
|
||||
{
|
||||
int old = ip_rt_secret_interval;
|
||||
int ret = proc_dointvec_jiffies(ctl, write, filp, buffer, lenp, ppos);
|
||||
int ret = proc_dointvec_jiffies(ctl, write, buffer, lenp, ppos);
|
||||
|
||||
rt_secret_reschedule(old);
|
||||
|
||||
|
@@ -36,7 +36,7 @@ static void set_local_port_range(int range[2])
|
||||
}
|
||||
|
||||
/* Validate changes from /proc interface. */
|
||||
static int ipv4_local_port_range(ctl_table *table, int write, struct file *filp,
|
||||
static int ipv4_local_port_range(ctl_table *table, int write,
|
||||
void __user *buffer,
|
||||
size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
@@ -51,7 +51,7 @@ static int ipv4_local_port_range(ctl_table *table, int write, struct file *filp,
|
||||
};
|
||||
|
||||
inet_get_local_port_range(range, range + 1);
|
||||
ret = proc_dointvec_minmax(&tmp, write, filp, buffer, lenp, ppos);
|
||||
ret = proc_dointvec_minmax(&tmp, write, buffer, lenp, ppos);
|
||||
|
||||
if (write && ret == 0) {
|
||||
if (range[1] < range[0])
|
||||
@@ -91,7 +91,7 @@ static int ipv4_sysctl_local_port_range(ctl_table *table,
|
||||
}
|
||||
|
||||
|
||||
static int proc_tcp_congestion_control(ctl_table *ctl, int write, struct file * filp,
|
||||
static int proc_tcp_congestion_control(ctl_table *ctl, int write,
|
||||
void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
char val[TCP_CA_NAME_MAX];
|
||||
@@ -103,7 +103,7 @@ static int proc_tcp_congestion_control(ctl_table *ctl, int write, struct file *
|
||||
|
||||
tcp_get_default_congestion_control(val);
|
||||
|
||||
ret = proc_dostring(&tbl, write, filp, buffer, lenp, ppos);
|
||||
ret = proc_dostring(&tbl, write, buffer, lenp, ppos);
|
||||
if (write && ret == 0)
|
||||
ret = tcp_set_default_congestion_control(val);
|
||||
return ret;
|
||||
@@ -129,7 +129,7 @@ static int sysctl_tcp_congestion_control(ctl_table *table,
|
||||
}
|
||||
|
||||
static int proc_tcp_available_congestion_control(ctl_table *ctl,
|
||||
int write, struct file * filp,
|
||||
int write,
|
||||
void __user *buffer, size_t *lenp,
|
||||
loff_t *ppos)
|
||||
{
|
||||
@@ -140,13 +140,13 @@ static int proc_tcp_available_congestion_control(ctl_table *ctl,
|
||||
if (!tbl.data)
|
||||
return -ENOMEM;
|
||||
tcp_get_available_congestion_control(tbl.data, TCP_CA_BUF_MAX);
|
||||
ret = proc_dostring(&tbl, write, filp, buffer, lenp, ppos);
|
||||
ret = proc_dostring(&tbl, write, buffer, lenp, ppos);
|
||||
kfree(tbl.data);
|
||||
return ret;
|
||||
}
|
||||
|
||||
static int proc_allowed_congestion_control(ctl_table *ctl,
|
||||
int write, struct file * filp,
|
||||
int write,
|
||||
void __user *buffer, size_t *lenp,
|
||||
loff_t *ppos)
|
||||
{
|
||||
@@ -158,7 +158,7 @@ static int proc_allowed_congestion_control(ctl_table *ctl,
|
||||
return -ENOMEM;
|
||||
|
||||
tcp_get_allowed_congestion_control(tbl.data, tbl.maxlen);
|
||||
ret = proc_dostring(&tbl, write, filp, buffer, lenp, ppos);
|
||||
ret = proc_dostring(&tbl, write, buffer, lenp, ppos);
|
||||
if (write && ret == 0)
|
||||
ret = tcp_set_allowed_congestion_control(tbl.data);
|
||||
kfree(tbl.data);
|
||||
|
@@ -3986,14 +3986,14 @@ static void ipv6_ifa_notify(int event, struct inet6_ifaddr *ifp)
|
||||
#ifdef CONFIG_SYSCTL
|
||||
|
||||
static
|
||||
int addrconf_sysctl_forward(ctl_table *ctl, int write, struct file * filp,
|
||||
int addrconf_sysctl_forward(ctl_table *ctl, int write,
|
||||
void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
int *valp = ctl->data;
|
||||
int val = *valp;
|
||||
int ret;
|
||||
|
||||
ret = proc_dointvec(ctl, write, filp, buffer, lenp, ppos);
|
||||
ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
|
||||
|
||||
if (write)
|
||||
ret = addrconf_fixup_forwarding(ctl, valp, val);
|
||||
@@ -4090,14 +4090,14 @@ static int addrconf_disable_ipv6(struct ctl_table *table, int *p, int old)
|
||||
}
|
||||
|
||||
static
|
||||
int addrconf_sysctl_disable(ctl_table *ctl, int write, struct file * filp,
|
||||
int addrconf_sysctl_disable(ctl_table *ctl, int write,
|
||||
void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
int *valp = ctl->data;
|
||||
int val = *valp;
|
||||
int ret;
|
||||
|
||||
ret = proc_dointvec(ctl, write, filp, buffer, lenp, ppos);
|
||||
ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
|
||||
|
||||
if (write)
|
||||
ret = addrconf_disable_ipv6(ctl, valp, val);
|
||||
|
@@ -1735,7 +1735,7 @@ static void ndisc_warn_deprecated_sysctl(struct ctl_table *ctl,
|
||||
}
|
||||
}
|
||||
|
||||
int ndisc_ifinfo_sysctl_change(struct ctl_table *ctl, int write, struct file * filp, void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
int ndisc_ifinfo_sysctl_change(struct ctl_table *ctl, int write, void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
struct net_device *dev = ctl->extra1;
|
||||
struct inet6_dev *idev;
|
||||
@@ -1746,16 +1746,16 @@ int ndisc_ifinfo_sysctl_change(struct ctl_table *ctl, int write, struct file * f
|
||||
ndisc_warn_deprecated_sysctl(ctl, "syscall", dev ? dev->name : "default");
|
||||
|
||||
if (strcmp(ctl->procname, "retrans_time") == 0)
|
||||
ret = proc_dointvec(ctl, write, filp, buffer, lenp, ppos);
|
||||
ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
|
||||
|
||||
else if (strcmp(ctl->procname, "base_reachable_time") == 0)
|
||||
ret = proc_dointvec_jiffies(ctl, write,
|
||||
filp, buffer, lenp, ppos);
|
||||
buffer, lenp, ppos);
|
||||
|
||||
else if ((strcmp(ctl->procname, "retrans_time_ms") == 0) ||
|
||||
(strcmp(ctl->procname, "base_reachable_time_ms") == 0))
|
||||
ret = proc_dointvec_ms_jiffies(ctl, write,
|
||||
filp, buffer, lenp, ppos);
|
||||
buffer, lenp, ppos);
|
||||
else
|
||||
ret = -1;
|
||||
|
||||
|
@@ -2524,13 +2524,13 @@ static const struct file_operations rt6_stats_seq_fops = {
|
||||
#ifdef CONFIG_SYSCTL
|
||||
|
||||
static
|
||||
int ipv6_sysctl_rtcache_flush(ctl_table *ctl, int write, struct file * filp,
|
||||
int ipv6_sysctl_rtcache_flush(ctl_table *ctl, int write,
|
||||
void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
struct net *net = current->nsproxy->net_ns;
|
||||
int delay = net->ipv6.sysctl.flush_delay;
|
||||
if (write) {
|
||||
proc_dointvec(ctl, write, filp, buffer, lenp, ppos);
|
||||
proc_dointvec(ctl, write, buffer, lenp, ppos);
|
||||
fib6_run_gc(delay <= 0 ? ~0UL : (unsigned long)delay, net);
|
||||
return 0;
|
||||
} else
|
||||
|
@@ -73,12 +73,12 @@ static int min_lap_keepalive_time = 100; /* 100us */
|
||||
/* For other sysctl, I've no idea of the range. Maybe Dag could help
|
||||
* us on that - Jean II */
|
||||
|
||||
static int do_devname(ctl_table *table, int write, struct file *filp,
|
||||
static int do_devname(ctl_table *table, int write,
|
||||
void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
int ret;
|
||||
|
||||
ret = proc_dostring(table, write, filp, buffer, lenp, ppos);
|
||||
ret = proc_dostring(table, write, buffer, lenp, ppos);
|
||||
if (ret == 0 && write) {
|
||||
struct ias_value *val;
|
||||
|
||||
@@ -90,12 +90,12 @@ static int do_devname(ctl_table *table, int write, struct file *filp,
|
||||
}
|
||||
|
||||
|
||||
static int do_discovery(ctl_table *table, int write, struct file *filp,
|
||||
static int do_discovery(ctl_table *table, int write,
|
||||
void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
int ret;
|
||||
|
||||
ret = proc_dointvec(table, write, filp, buffer, lenp, ppos);
|
||||
ret = proc_dointvec(table, write, buffer, lenp, ppos);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
|
@@ -1496,14 +1496,14 @@ static int ip_vs_zero_all(void)
|
||||
|
||||
|
||||
static int
|
||||
proc_do_defense_mode(ctl_table *table, int write, struct file * filp,
|
||||
proc_do_defense_mode(ctl_table *table, int write,
|
||||
void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
int *valp = table->data;
|
||||
int val = *valp;
|
||||
int rc;
|
||||
|
||||
rc = proc_dointvec(table, write, filp, buffer, lenp, ppos);
|
||||
rc = proc_dointvec(table, write, buffer, lenp, ppos);
|
||||
if (write && (*valp != val)) {
|
||||
if ((*valp < 0) || (*valp > 3)) {
|
||||
/* Restore the correct value */
|
||||
@@ -1517,7 +1517,7 @@ proc_do_defense_mode(ctl_table *table, int write, struct file * filp,
|
||||
|
||||
|
||||
static int
|
||||
proc_do_sync_threshold(ctl_table *table, int write, struct file *filp,
|
||||
proc_do_sync_threshold(ctl_table *table, int write,
|
||||
void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
int *valp = table->data;
|
||||
@@ -1527,7 +1527,7 @@ proc_do_sync_threshold(ctl_table *table, int write, struct file *filp,
|
||||
/* backup the value first */
|
||||
memcpy(val, valp, sizeof(val));
|
||||
|
||||
rc = proc_dointvec(table, write, filp, buffer, lenp, ppos);
|
||||
rc = proc_dointvec(table, write, buffer, lenp, ppos);
|
||||
if (write && (valp[0] < 0 || valp[1] < 0 || valp[0] >= valp[1])) {
|
||||
/* Restore the correct value */
|
||||
memcpy(valp, val, sizeof(val));
|
||||
|
@@ -226,7 +226,7 @@ static char nf_log_sysctl_fnames[NFPROTO_NUMPROTO-NFPROTO_UNSPEC][3];
|
||||
static struct ctl_table nf_log_sysctl_table[NFPROTO_NUMPROTO+1];
|
||||
static struct ctl_table_header *nf_log_dir_header;
|
||||
|
||||
static int nf_log_proc_dostring(ctl_table *table, int write, struct file *filp,
|
||||
static int nf_log_proc_dostring(ctl_table *table, int write,
|
||||
void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
const struct nf_logger *logger;
|
||||
@@ -260,7 +260,7 @@ static int nf_log_proc_dostring(ctl_table *table, int write, struct file *filp,
|
||||
table->data = "NONE";
|
||||
else
|
||||
table->data = logger->name;
|
||||
r = proc_dostring(table, write, filp, buffer, lenp, ppos);
|
||||
r = proc_dostring(table, write, buffer, lenp, ppos);
|
||||
mutex_unlock(&nf_log_mutex);
|
||||
}
|
||||
|
||||
|
@@ -56,7 +56,7 @@ void phonet_get_local_port_range(int *min, int *max)
|
||||
} while (read_seqretry(&local_port_range_lock, seq));
|
||||
}
|
||||
|
||||
static int proc_local_port_range(ctl_table *table, int write, struct file *filp,
|
||||
static int proc_local_port_range(ctl_table *table, int write,
|
||||
void __user *buffer,
|
||||
size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
@@ -70,7 +70,7 @@ static int proc_local_port_range(ctl_table *table, int write, struct file *filp,
|
||||
.extra2 = &local_port_range_max,
|
||||
};
|
||||
|
||||
ret = proc_dointvec_minmax(&tmp, write, filp, buffer, lenp, ppos);
|
||||
ret = proc_dointvec_minmax(&tmp, write, buffer, lenp, ppos);
|
||||
|
||||
if (write && ret == 0) {
|
||||
if (range[1] < range[0])
|
||||
|
@@ -56,7 +56,7 @@ rpc_unregister_sysctl(void)
|
||||
}
|
||||
}
|
||||
|
||||
static int proc_do_xprt(ctl_table *table, int write, struct file *file,
|
||||
static int proc_do_xprt(ctl_table *table, int write,
|
||||
void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
char tmpbuf[256];
|
||||
@@ -71,7 +71,7 @@ static int proc_do_xprt(ctl_table *table, int write, struct file *file,
|
||||
}
|
||||
|
||||
static int
|
||||
proc_dodebug(ctl_table *table, int write, struct file *file,
|
||||
proc_dodebug(ctl_table *table, int write,
|
||||
void __user *buffer, size_t *lenp, loff_t *ppos)
|
||||
{
|
||||
char tmpbuf[20], c, *s;
|
||||
|
@@ -80,7 +80,7 @@ struct kmem_cache *svc_rdma_ctxt_cachep;
|
||||
* current value.
|
||||
*/
|
||||
static int read_reset_stat(ctl_table *table, int write,
|
||||
struct file *filp, void __user *buffer, size_t *lenp,
|
||||
void __user *buffer, size_t *lenp,
|
||||
loff_t *ppos)
|
||||
{
|
||||
atomic_t *stat = (atomic_t *)table->data;
|
||||
|
Reference in New Issue
Block a user