ixgbevf: make use of BIT() macro to avoid shift of signed values
Also cleanup a case where we're bit shifting a value into place, and use an unsigned constant. Make use of the unsigned postfix in places where BIT() macro is not appropriate. Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This commit is contained in:

committed by
Jeff Kirsher

parent
3e973dc4b9
commit
8d055cc0c8
@@ -166,7 +166,8 @@ static void ixgbevf_get_regs(struct net_device *netdev,
|
||||
|
||||
memset(p, 0, regs_len);
|
||||
|
||||
regs->version = (1 << 24) | hw->revision_id << 16 | hw->device_id;
|
||||
/* generate a number suitable for ethtool's register version */
|
||||
regs->version = (1u << 24) | (hw->revision_id << 16) | hw->device_id;
|
||||
|
||||
/* General Registers */
|
||||
regs_buff[0] = IXGBE_READ_REG(hw, IXGBE_VFCTRL);
|
||||
|
Reference in New Issue
Block a user