xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: rtl8192e: Fix use after free in _rtl92e_pci_disconnect()

Browse Source 
commit b535917c51acc97fb0761b1edec85f1f3d02bda4 upstream.

The free_rtllib() function frees the "dev" pointer so there is use
after free on the next line.  Re-arrange things to avoid that.

Fixes: 66898177e7 ("staging: rtl8192e: Fix unload/reload problem")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211117072016.GA5237@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter
2021-11-17 10:20:16 +03:00
committed by Greg Kroah-Hartman
parent 0bfed81b2c
commit 8d0163cec7
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
View File

@@ -2551,13 +2551,14 @@ static void _rtl92e_pci_disconnect(struct pci_dev *pdev)
free_irq(dev->irq, dev); free_irq(dev->irq, dev);
priv->irq = 0; priv->irq = 0;
} }
free_rtllib(dev);
if (dev->mem_start != 0) { if (dev->mem_start != 0) {
iounmap((void __iomem *)dev->mem_start); iounmap((void __iomem *)dev->mem_start);
release_mem_region(pci_resource_start(pdev, 1), release_mem_region(pci_resource_start(pdev, 1),
pci_resource_len(pdev, 1)); pci_resource_len(pdev, 1));
} }
free_rtllib(dev);
} else { } else {
priv = rtllib_priv(dev); priv = rtllib_priv(dev);
} }