[NET]: Fix running without sysfs
When sysfs support is compiled out the kernel still keeps and maintains the kobject tree. So it is not safe to skip our kobject reference counting or to avoid becoming members of the kobject tree. It is safe to not add the networking specific sysfs attributes. This patch removes the sysfs special cases from net/core/dev.c renames functions from netdev_sysfs_xxxx to netdev_kobject_xxxx and always compiles in net-sysfs.c net-sysfs.c is modified with a CONFIG_SYSFS guard around the parts that are actually sysfs specific. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
bb293e6a24
commit
8b41d1887d
@@ -18,6 +18,7 @@
|
||||
#include <linux/wireless.h>
|
||||
#include <net/iw_handler.h>
|
||||
|
||||
#ifdef CONFIG_SYSFS
|
||||
static const char fmt_hex[] = "%#x\n";
|
||||
static const char fmt_long_hex[] = "%#lx\n";
|
||||
static const char fmt_dec[] = "%d\n";
|
||||
@@ -392,6 +393,8 @@ static struct attribute_group wireless_group = {
|
||||
};
|
||||
#endif
|
||||
|
||||
#endif /* CONFIG_SYSFS */
|
||||
|
||||
#ifdef CONFIG_HOTPLUG
|
||||
static int netdev_uevent(struct device *d, char **envp,
|
||||
int num_envp, char *buf, int size)
|
||||
@@ -435,7 +438,9 @@ static void netdev_release(struct device *d)
|
||||
static struct class net_class = {
|
||||
.name = "net",
|
||||
.dev_release = netdev_release,
|
||||
#ifdef CONFIG_SYSFS
|
||||
.dev_attrs = net_class_attributes,
|
||||
#endif /* CONFIG_SYSFS */
|
||||
#ifdef CONFIG_HOTPLUG
|
||||
.dev_uevent = netdev_uevent,
|
||||
#endif
|
||||
@@ -444,7 +449,7 @@ static struct class net_class = {
|
||||
/* Delete sysfs entries but hold kobject reference until after all
|
||||
* netdev references are gone.
|
||||
*/
|
||||
void netdev_unregister_sysfs(struct net_device * net)
|
||||
void netdev_unregister_kobject(struct net_device * net)
|
||||
{
|
||||
struct device *dev = &(net->dev);
|
||||
|
||||
@@ -453,7 +458,7 @@ void netdev_unregister_sysfs(struct net_device * net)
|
||||
}
|
||||
|
||||
/* Create sysfs entries for network device. */
|
||||
int netdev_register_sysfs(struct net_device *net)
|
||||
int netdev_register_kobject(struct net_device *net)
|
||||
{
|
||||
struct device *dev = &(net->dev);
|
||||
struct attribute_group **groups = net->sysfs_groups;
|
||||
@@ -466,6 +471,7 @@ int netdev_register_sysfs(struct net_device *net)
|
||||
BUILD_BUG_ON(BUS_ID_SIZE < IFNAMSIZ);
|
||||
strlcpy(dev->bus_id, net->name, BUS_ID_SIZE);
|
||||
|
||||
#ifdef CONFIG_SYSFS
|
||||
if (net->get_stats)
|
||||
*groups++ = &netstat_group;
|
||||
|
||||
@@ -473,11 +479,12 @@ int netdev_register_sysfs(struct net_device *net)
|
||||
if (net->wireless_handlers && net->wireless_handlers->get_wireless_stats)
|
||||
*groups++ = &wireless_group;
|
||||
#endif
|
||||
#endif /* CONFIG_SYSFS */
|
||||
|
||||
return device_add(dev);
|
||||
}
|
||||
|
||||
int netdev_sysfs_init(void)
|
||||
int netdev_kobject_init(void)
|
||||
{
|
||||
return class_register(&net_class);
|
||||
}
|
||||
|
Reference in New Issue
Block a user