xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: fbtft: Don't spam logs when probe is deferred

Browse Source 
[ Upstream commit 37667f6e57712cef5652fa67f1cbd1299e204d94 ]

When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().

Fixes: c440eee1a7 ("Staging: fbtft: Switch to the gpio descriptor interface")
Cc: Nishad Kamdar <nishadkamdar@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210503172114.27891-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Andy Shevchenko
2021-05-03 20:21:11 +03:00
committed by Greg Kroah-Hartman
parent 7a42f3c30d
commit 8b195380cd
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/fbtft/fbtft-core.c
View File

@@ -75,20 +75,16 @@ static int fbtft_request_one_gpio(struct fbtft_par *par,
struct gpio_desc **gpiop) struct gpio_desc **gpiop)
{ {
struct device *dev = par->info->device; struct device *dev = par->info->device;
int ret = 0;
*gpiop = devm_gpiod_get_index_optional(dev, name, index, *gpiop = devm_gpiod_get_index_optional(dev, name, index,
GPIOD_OUT_LOW); GPIOD_OUT_LOW);
if (IS_ERR(*gpiop)) { if (IS_ERR(*gpiop))
ret = PTR_ERR(*gpiop); return dev_err_probe(dev, PTR_ERR(*gpiop), "Failed to request %s GPIO\n", name);
dev_err(dev,
"Failed to request %s GPIO: %d\n", name, ret);
return ret;
}
fbtft_par_dbg(DEBUG_REQUEST_GPIOS, par, "%s: '%s' GPIO\n", fbtft_par_dbg(DEBUG_REQUEST_GPIOS, par, "%s: '%s' GPIO\n",
__func__, name); __func__, name);
return ret; return 0;
} }
static int fbtft_request_gpios(struct fbtft_par *par) static int fbtft_request_gpios(struct fbtft_par *par)