xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net/ipv6: Remove unncessary check on f6i in fib6_check

Browse Source 
Dan reported an imbalance in fib6_check on use of f6i and checking
whether it is null. Since fib6_check is only called if f6i is non-null,
remove the unnecessary check.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David Ahern
2018-04-20 15:38:03 -07:00
committed by David S. Miller
parent a68886a691
commit 8ae869714b
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
net/ipv6/route.c
View File

@@ -2130,8 +2130,7 @@ static bool fib6_check(struct fib6_info *f6i, u32 cookie)
{ {
u32 rt_cookie = 0; u32 rt_cookie = 0;
if ((f6i && !fib6_get_cookie_safe(f6i, &rt_cookie)) || if (!fib6_get_cookie_safe(f6i, &rt_cookie) || rt_cookie != cookie)
rt_cookie != cookie)
return false; return false;
if (fib6_check_expired(f6i)) if (fib6_check_expired(f6i))