xfs: remove the ip argument to xfs_defer_finish

And instead require callers to explicitly join the inode using
xfs_defer_ijoin.  Also consolidate the defer error handling in
a few places using a goto label.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
This commit is contained in:
Christoph Hellwig
2017-08-28 10:21:04 -07:00
committed by Darrick J. Wong
parent 882d8785fb
commit 8ad7c629b1
15 changed files with 129 additions and 116 deletions

View File

@@ -274,7 +274,7 @@ xfs_iomap_write_direct(
/*
* Complete the transaction
*/
error = xfs_defer_finish(&tp, &dfops, NULL);
error = xfs_defer_finish(&tp, &dfops);
if (error)
goto out_bmap_cancel;
@@ -784,7 +784,7 @@ xfs_iomap_write_allocate(
if (error)
goto trans_cancel;
error = xfs_defer_finish(&tp, &dfops, NULL);
error = xfs_defer_finish(&tp, &dfops);
if (error)
goto trans_cancel;
@@ -906,7 +906,7 @@ xfs_iomap_write_unwritten(
xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);
}
error = xfs_defer_finish(&tp, &dfops, NULL);
error = xfs_defer_finish(&tp, &dfops);
if (error)
goto error_on_bmapi_transaction;