tty: replace ->proc_fops with ->proc_show
Just set up the show callback in the tty_operations, and use proc_create_single_data to create the file without additional boilerplace code. Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
@@ -1829,19 +1829,6 @@ static int uart_proc_show(struct seq_file *m, void *v)
|
||||
uart_line_info(m, drv, i);
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int uart_proc_open(struct inode *inode, struct file *file)
|
||||
{
|
||||
return single_open(file, uart_proc_show, PDE_DATA(inode));
|
||||
}
|
||||
|
||||
static const struct file_operations uart_proc_fops = {
|
||||
.owner = THIS_MODULE,
|
||||
.open = uart_proc_open,
|
||||
.read = seq_read,
|
||||
.llseek = seq_lseek,
|
||||
.release = single_release,
|
||||
};
|
||||
#endif
|
||||
|
||||
#if defined(CONFIG_SERIAL_CORE_CONSOLE) || defined(CONFIG_CONSOLE_POLL)
|
||||
@@ -2415,7 +2402,7 @@ static const struct tty_operations uart_ops = {
|
||||
.break_ctl = uart_break_ctl,
|
||||
.wait_until_sent= uart_wait_until_sent,
|
||||
#ifdef CONFIG_PROC_FS
|
||||
.proc_fops = &uart_proc_fops,
|
||||
.proc_show = uart_proc_show,
|
||||
#endif
|
||||
.tiocmget = uart_tiocmget,
|
||||
.tiocmset = uart_tiocmset,
|
||||
|
Reference in New Issue
Block a user