[DCCP]: calling dccp_v{4,6}_reqsk_send_ack is a BUG
This patch removes two functions, the send_ack functions of request_sock, which are not called/used by the DCCP code. It is correct that these functions are not called, below is a justification why calling these functions (on a passive socket in the LISTEN/RESPOND state) would mean a DCCP protocol violation. A) Background: using request_sock in TCP:
Этот коммит содержится в:

коммит произвёл
David S. Miller

родитель
f6484f7c7a
Коммит
8a73cd09d9
@@ -11,6 +11,7 @@
|
||||
*/
|
||||
|
||||
#include <linux/dccp.h>
|
||||
#include <linux/kernel.h>
|
||||
#include <linux/skbuff.h>
|
||||
#include <linux/timer.h>
|
||||
|
||||
@@ -283,3 +284,12 @@ int dccp_child_process(struct sock *parent, struct sock *child,
|
||||
}
|
||||
|
||||
EXPORT_SYMBOL_GPL(dccp_child_process);
|
||||
|
||||
void dccp_reqsk_send_ack(struct sk_buff *skb, struct request_sock *rsk)
|
||||
{
|
||||
pr_info(KERN_WARNING "DCCP: ACK packets are never sent in "
|
||||
"LISTEN/RESPOND state\n");
|
||||
dump_stack();
|
||||
}
|
||||
|
||||
EXPORT_SYMBOL_GPL(dccp_reqsk_send_ack);
|
||||
|
Ссылка в новой задаче
Block a user