Revert "net: simplify sock_poll_wait"
This reverts commit dd979b4df8
.
This broke tcp_poll for SMC fallback: An AF_SMC socket establishes an
internal TCP socket for the initial handshake with the remote peer.
Whenever the SMC connection can not be established this TCP socket is
used as a fallback. All socket operations on the SMC socket are then
forwarded to the TCP socket. In case of poll, the file->private_data
pointer references the SMC socket because the TCP socket has no file
assigned. This causes tcp_poll to wait on the wrong socket.
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
6b7a02f708
commit
89ab066d42
@@ -717,7 +717,7 @@ static __poll_t tipc_poll(struct file *file, struct socket *sock,
|
||||
struct tipc_sock *tsk = tipc_sk(sk);
|
||||
__poll_t revents = 0;
|
||||
|
||||
sock_poll_wait(file, wait);
|
||||
sock_poll_wait(file, sock, wait);
|
||||
|
||||
if (sk->sk_shutdown & RCV_SHUTDOWN)
|
||||
revents |= EPOLLRDHUP | EPOLLIN | EPOLLRDNORM;
|
||||
|
Reference in New Issue
Block a user