dmaengine: consolidate assignment of DMA cookies
Everyone deals with assigning DMA cookies in the same way (it's part of the API so they should be), so lets consolidate the common code into a helper function to avoid this duplication. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Tested-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Jassi Brar <jassisinghbrar@gmail.com> [imx-sdma.c & mxs-dma.c] Tested-by: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
This commit is contained in:

committed by
Vinod Koul

parent
d2ebfb335b
commit
884485e1f1
@@ -867,14 +867,7 @@ static dma_cookie_t idmac_tx_submit(struct dma_async_tx_descriptor *tx)
|
||||
|
||||
dev_dbg(dev, "Submitting sg %p\n", &desc->sg[0]);
|
||||
|
||||
cookie = ichan->dma_chan.cookie;
|
||||
|
||||
if (++cookie < 0)
|
||||
cookie = 1;
|
||||
|
||||
/* from dmaengine.h: "last cookie value returned to client" */
|
||||
ichan->dma_chan.cookie = cookie;
|
||||
tx->cookie = cookie;
|
||||
cookie = dma_cookie_assign(tx);
|
||||
|
||||
/* ipu->lock can be taken under ichan->lock, but not v.v. */
|
||||
spin_lock_irqsave(&ichan->lock, flags);
|
||||
|
Reference in New Issue
Block a user