net: more accurate skb truesize
skb truesize currently accounts for sk_buff struct and part of skb head. kmalloc() roundings are also ignored. Considering that skb_shared_info is larger than sk_buff, its time to take it into account for better memory accounting. This patch introduces SKB_TRUESIZE(X) macro to centralize various assumptions into a single place. At skb alloc phase, we put skb_shared_info struct at the exact end of skb head, to allow a better use of memory (lowering number of reallocations), since kmalloc() gives us power-of-two memory blocks. Unless SLUB/SLUB debug is active, both skb->head and skb_shared_info are aligned to cache lines, as before. Note: This patch might trigger performance regressions because of misconfigured protocol stacks, hitting per socket or global memory limits that were previously not reached. But its a necessary step for a more accurate memory accounting. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> CC: Andi Kleen <ak@linux.intel.com> CC: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committad av
David S. Miller

förälder
97ba0eb64c
incheckning
87fb4b7b53
@@ -1299,7 +1299,7 @@ SCTP_STATIC __init int sctp_init(void)
|
||||
max_share = min(4UL*1024*1024, limit);
|
||||
|
||||
sysctl_sctp_rmem[0] = SK_MEM_QUANTUM; /* give each asoc 1 page min */
|
||||
sysctl_sctp_rmem[1] = (1500 *(sizeof(struct sk_buff) + 1));
|
||||
sysctl_sctp_rmem[1] = 1500 * SKB_TRUESIZE(1);
|
||||
sysctl_sctp_rmem[2] = max(sysctl_sctp_rmem[1], max_share);
|
||||
|
||||
sysctl_sctp_wmem[0] = SK_MEM_QUANTUM;
|
||||
|
Referens i nytt ärende
Block a user