xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: ieee802154: handle iftypes as u32

Browse Source 
[ Upstream commit 451dc48c806a7ce9fbec5e7a24ccf4b2c936e834 ]

This patch fixes an issue that an u32 netlink value is handled as a
signed enum value which doesn't fit into the range of u32 netlink type.
If it's handled as -1 value some BIT() evaluation ends in a
shift-out-of-bounds issue. To solve the issue we set the to u32 max which
is s32 "-1" value to keep backwards compatibility and let the followed enum
values start counting at 0. This brings the compiler to never handle the
enum as signed and a check if the value is above NL802154_IFTYPE_MAX should
filter -1 out.

Fixes: f3ea5e4423 ("ieee802154: add new interface command")
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20211112030916.685793-1-aahringo@redhat.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Alexander Aring
2021-11-11 22:09:16 -05:00
committed by Greg Kroah-Hartman
parent 2925aadd1f
commit 8730a679c3
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
include/net/nl802154.h
View File

@@ -19,6 +19,8 @@
* *
*/ */
#include <linux/types.h>
#define NL802154_GENL_NAME "nl802154" #define NL802154_GENL_NAME "nl802154"
enum nl802154_commands { enum nl802154_commands {
@@ -150,10 +152,9 @@ enum nl802154_attrs {
}; };
enum nl802154_iftype { enum nl802154_iftype {
/* for backwards compatibility TODO */ NL802154_IFTYPE_UNSPEC = (~(__u32)0),
NL802154_IFTYPE_UNSPEC = -1,
NL802154_IFTYPE_NODE, NL802154_IFTYPE_NODE = 0,
NL802154_IFTYPE_MONITOR, NL802154_IFTYPE_MONITOR,
NL802154_IFTYPE_COORD, NL802154_IFTYPE_COORD,