ALSA: Make snd_printd() and snd_printdd() inline
Because currently snd_printd() and snd_printdd() macros are expanded to empty when CONFIG_SND_DEBUG=n, a compile warning like below appears sometimes, and we had to covert it by ugly ifdefs: sound/pci/hda/patch_sigmatel.c: In function ‘stac92hd71bxx_fixup_hp’: sound/pci/hda/patch_sigmatel.c:2434:24: warning: unused variable ‘spec’ [-Wunused-variable] For "fixing" these issues better, this patch replaces snd_printd() and snd_printdd() definitions with empty inline functions instead of macros. This should have the same effect but shut up warnings like above. But since we had already put ifdefs, changing to inline functions would trigger compile errors. So, such ifdefs is removed in this patch. In addition, snd_pci_quirk name field is defined only when CONFIG_SND_DEBUG_VERBOSE is set, and the reference to it in snd_printdd() argument triggers the build errors, too. For avoiding these errors, introduce a new macro snd_pci_quirk_name() that is defined no matter how the debug option is set. Reported-by: Stratos Karafotis <stratosk@semaphore.gr> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
@@ -698,9 +698,7 @@ static void set_pin_targets(struct hda_codec *codec,
|
||||
|
||||
static void apply_fixup(struct hda_codec *codec, int id, int action, int depth)
|
||||
{
|
||||
#ifdef CONFIG_SND_DEBUG_VERBOSE
|
||||
const char *modelname = codec->fixup_name;
|
||||
#endif
|
||||
|
||||
while (id >= 0) {
|
||||
const struct hda_fixup *fix = codec->fixup_list + id;
|
||||
|
@@ -1579,9 +1579,7 @@ static void debug_show_configs(struct hda_codec *codec,
|
||||
struct auto_pin_cfg *cfg)
|
||||
{
|
||||
struct hda_gen_spec *spec = codec->spec;
|
||||
#ifdef CONFIG_SND_DEBUG_VERBOSE
|
||||
static const char * const lo_type[3] = { "LO", "SP", "HP" };
|
||||
#endif
|
||||
int i;
|
||||
|
||||
debug_badness("multi_outs = %x/%x/%x/%x : %x/%x/%x/%x (type %s)\n",
|
||||
|
Reference in New Issue
Block a user