xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

objtool: Fix gcov check for older versions of GCC

Browse Source 
Objtool tries to silence 'unreachable instruction' warnings when it
detects gcov is enabled, because gcov produces a lot of unreachable
instructions and they don't really matter.

However, the 0-day bot is still reporting some unreachable instruction
warnings with CONFIG_GCOV_KERNEL=y on GCC 4.6.4.

As it turns out, objtool's gcov detection doesn't work with older
versions of GCC because they don't create a bunch of symbols with the
'gcov.' prefix like newer versions of GCC do.

Move the gcov check out of objtool and instead just create a new
'--no-unreachable' flag which can be passed in by the kernel Makefile
when CONFIG_GCOV_KERNEL is defined.

Also rename the 'nofp' variable to 'no_fp' for consistency with the new
'no_unreachable' variable.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 9cfffb1168 ("objtool: Skip all "unreachable instruction" warnings for gcov kernels")
Link: http://lkml.kernel.org/r/c243dc78eb2ffdabb6e927844dea39b6033cd395.1500939244.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Josh Poimboeuf
2017-07-24 18:34:14 -05:00
committed by Ingo Molnar
parent 9683a64fc3
commit 867ac9d737
5 changed files with 17 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools/objtool/builtin-orc.c
View File

@@ -37,7 +37,7 @@ static const char *orc_usage[] = {
};
extern const struct option check_options[];
extern bool nofp;
extern bool no_fp, no_unreachable;
int cmd_orc(int argc, const char **argv)
{
@@ -51,7 +51,7 @@ int cmd_orc(int argc, const char **argv)
objname = argv[0];
return check(objname, nofp, true);
return check(objname, no_fp, no_unreachable, true);
}