USB: Push BKL on open down into the drivers
Straightforward push into the drivers to allow auditing individual drivers separately Signed-off-by: Oliver Neukum <oliver@neukum.org> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> Cc: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
f9de332ebf
commit
86266452f8
@@ -24,6 +24,7 @@
|
||||
#include <linux/module.h>
|
||||
#include <linux/completion.h>
|
||||
#include <linux/mutex.h>
|
||||
#include <linux/smp_lock.h>
|
||||
#include <asm/uaccess.h>
|
||||
#include <linux/usb.h>
|
||||
|
||||
@@ -226,16 +227,20 @@ static int idmouse_open(struct inode *inode, struct file *file)
|
||||
struct usb_interface *interface;
|
||||
int result;
|
||||
|
||||
lock_kernel();
|
||||
/* get the interface from minor number and driver information */
|
||||
interface = usb_find_interface (&idmouse_driver, iminor (inode));
|
||||
if (!interface)
|
||||
if (!interface) {
|
||||
unlock_kernel();
|
||||
return -ENODEV;
|
||||
}
|
||||
|
||||
mutex_lock(&open_disc_mutex);
|
||||
/* get the device information block from the interface */
|
||||
dev = usb_get_intfdata(interface);
|
||||
if (!dev) {
|
||||
mutex_unlock(&open_disc_mutex);
|
||||
unlock_kernel();
|
||||
return -ENODEV;
|
||||
}
|
||||
|
||||
@@ -272,6 +277,7 @@ error:
|
||||
|
||||
/* unlock this device */
|
||||
mutex_unlock(&dev->lock);
|
||||
unlock_kernel();
|
||||
return result;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user