xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

memory: stm32-fmc2-ebi: add missing of_node_put for loop iteration

Browse Source 
[ Upstream commit 2f9dc6a357ff3b82c1e54d29fb5d52b8d4a0c587 ]

Early exits from for_each_available_child_of_node() should decrement the
node reference counter.  Reported by Coccinelle:

  drivers/memory/stm32-fmc2-ebi.c:1046:1-33: WARNING:
    Function "for_each_available_child_of_node" should have of_node_put() before return around line 1051.

Fixes: 66b8173a19 ("memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Christophe Kerello <christophe.kerello@foss.st.com>
Link: https://lore.kernel.org/r/20210423101815.119341-1-krzysztof.kozlowski@canonical.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Krzysztof Kozlowski
2021-04-23 12:18:14 +02:00
committed by Greg Kroah-Hartman
parent c385d93c3c
commit 84fa4a1063
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/memory/stm32-fmc2-ebi.c
View File

@@ -1048,16 +1048,19 @@ static int stm32_fmc2_ebi_parse_dt(struct stm32_fmc2_ebi *ebi)
if (ret) { if (ret) {
dev_err(dev, "could not retrieve reg property: %d\n", dev_err(dev, "could not retrieve reg property: %d\n",
ret); ret);
of_node_put(child);
return ret; return ret;
} }
if (bank >= FMC2_MAX_BANKS) { if (bank >= FMC2_MAX_BANKS) {
dev_err(dev, "invalid reg value: %d\n", bank); dev_err(dev, "invalid reg value: %d\n", bank);
of_node_put(child);
return -EINVAL; return -EINVAL;
} }
if (ebi->bank_assigned & BIT(bank)) { if (ebi->bank_assigned & BIT(bank)) {
dev_err(dev, "bank already assigned: %d\n", bank); dev_err(dev, "bank already assigned: %d\n", bank);
of_node_put(child);
return -EINVAL; return -EINVAL;
} }
@@ -1066,6 +1069,7 @@ static int stm32_fmc2_ebi_parse_dt(struct stm32_fmc2_ebi *ebi)
if (ret) { if (ret) {
dev_err(dev, "setup chip select %d failed: %d\n", dev_err(dev, "setup chip select %d failed: %d\n",
bank, ret); bank, ret);
of_node_put(child);
return ret; return ret;
} }
} }